refactor: Webhook delivery handlers#168
Merged
youbek merged 14 commits intoadcontextprotocol:mainfrom Dec 19, 2025
Merged
Conversation
youbek
force-pushed
the
feat/update-push-notification-implementation
branch
2 times, most recently
from
6e8a656 to
3988284
Compare
|
overall the architecture looks good and the type safety improvements are valuable. left some inline comments on specific areas that need attention before merging. summary of inline feedback:
the normalization logic for mcp vs a2a is well done though. |
nastassiafulconis
approved these changes
Dec 17, 2025
nastassiafulconis
left a comment
nastassiafulconis
left a comment
There was a problem hiding this comment.
this looks good! pending e2e tests but approving
…tead of WebhookPayload
BaiyuScope3
reviewed
Dec 18, 2025
BaiyuScope3
reviewed
Dec 18, 2025
BaiyuScope3
reviewed
Dec 18, 2025
youbek
force-pushed
the
feat/update-push-notification-implementation
branch
from
81122c6 to
edf4677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the implementation of the recent protocol change regarding push notifications. More context here: adcontextprotocol/adcp#268
PR shouldn't affect functionality of the webhooks. Mostly adds stricter typing and provides utility functions/function signatures.
Demo Looms (MCP)
sync creative approval and rejection
https://www.loom.com/share/930fb382e5404b6b8cd77196f5a398a0
media buy approval
https://www.loom.com/share/22ac869407ad4834ac5bae968b3c4237
Demo Looms (A2A)
sync creative approval
https://www.loom.com/share/11972d1ab2af4672a50363b74c531434
media buy approval
https://www.loom.com/share/7f86b1032164429882d906a3e07540da