-
Notifications
You must be signed in to change notification settings - Fork 25
feat: refactor push notification config spec to align with a2a #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
youbek
merged 12 commits into
main
from
feat/refactor-push-notification-config-to-align-with-a2a
Dec 9, 2025
Merged
feat: refactor push notification config spec to align with a2a #268
youbek
merged 12 commits into
main
from
feat/refactor-push-notification-config-to-align-with-a2a
Dec 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokelley
reviewed
Dec 5, 2025
static/schemas/source/media-buy/create-media-buy-async-response-input-required.json
Outdated
Show resolved
Hide resolved
static/schemas/source/media-buy/create-media-buy-async-response-input-required.json
Outdated
Show resolved
Hide resolved
… adcp will be aligned
static/schemas/source/media-buy/get-products-async-response-input-required.json
Show resolved
Hide resolved
EmmaLouise2018
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR redesigns how AdCP handles push notifications for async tasks. The key change is separating what data is sent (AdCP's responsibility) from how it's delivered (protocol's responsibility).
What Changed
Schema Changes
Renamed:
webhook-payload.json→mcp-webhook-payload.json(clarifies this envelope is MCP-specific)Created:
async-response-data.json- Union schema for all async response data typesworking,input-required, andsubmittedstatusesDeleted:
-async-response-completed.jsonand-async-response-failed.jsonfiles (6 total)completed/failed, we now use the existing task response schemas directlyWhy This Matters
Before: The webhook spec tried to be universal, which created confusion about how A2A's native push notifications fit in.
After:
mcp-webhook-payload.jsonas its envelope, with AdCP data inresultTask/TaskStatusUpdateEventmessages, with AdCP data instatus.message.parts[].dataThis makes it clear that AdCP only specifies the data layer, while each protocol handles delivery in its own way.
Files Changed
Schemas:
static/schemas/source/core/mcp-webhook-payload.json(renamed + simplified)static/schemas/source/core/async-response-data.json(new)static/schemas/source/media-buy/*-async-response-*.json(6 deleted, 9 remain)Documentation Updates
pushNotificationConfigis provided and the task runs asyncTaskvsTaskStatusUpdateEvent)