fix: Configure Conductor workspace with unique ports and fix database indentation

[bokelley]

Summary

• Fixed critical database initialization bug where sample data variables were out of scope
• Made Docker ports configurable via environment variables to support multiple instances
• Added documentation for Conductor workspace setup

Key Changes

1. Fixed Database Initialization Bug

The database.py file had a critical indentation error where principals_data and products_data variables were defined inside an if block but used outside it, causing UnboundLocalError.

2. Configurable Docker Ports

Updated docker-compose.yml to use environment variables for all ports:

• PostgreSQL: ${POSTGRES_PORT:-5432}
• MCP Server: ${ADCP_SALES_PORT:-8080}
• Admin UI: ${ADMIN_UI_PORT:-8001}

This allows multiple instances (e.g., Conductor workspaces) to run simultaneously without port conflicts.

3. Environment Configuration

Added port configuration to .env file and copied necessary files from root workspace.

4. Documentation

Created CONDUCTOR_SETUP.md with comprehensive setup instructions for Conductor workspaces.

Test Plan

• Fixed database initialization - containers now start successfully
• Verified all services run on configured ports
• Tested MCP server endpoint responds correctly
• Confirmed Admin UI redirects for authentication

🤖 Generated with Claude Code

[bokelley]

Thanks for the excellent review questions! I've addressed them in the latest commit:

1. Why port 5433 for PostgreSQL?

You're correct - it's to avoid conflicts. I've now documented this in the .env file:

# Server Ports (unique for this Conductor workspace)
# NOTE: Using non-standard ports to avoid conflicts with the main instance
# which typically runs on the default ports (5432, 8080, 8001)
POSTGRES_PORT=5433      # Default PostgreSQL port is 5432
ADCP_SALES_PORT=8081    # Default MCP server port is 8080
ADMIN_UI_PORT=8002      # Default Admin UI port is 8001

2. Other hardcoded ports

I did a comprehensive search and found many hardcoded ports throughout the codebase:

• Most Python files use environment variables with fallback defaults
• docker-compose-unified.yml still has fully hardcoded ports
• Test files and simulations use hardcoded URLs
• The codebase generally handles this well by using environment variables

3. Port availability validation

I've added two new scripts:

• check_ports.py: Python script that validates port availability
• docker-compose-safe.sh: Wrapper script that checks ports before starting services

Usage:

# Check ports manually
python3 check_ports.py

# Or use the safe wrapper
./docker-compose-safe.sh up -d

The port checker will show which ports are available/unavailable and provide helpful error messages if there are conflicts.