Update generated schemas to match AdCP v2.2.0 spec #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerated all Pydantic schemas from official AdCP spec at https://adcontextprotocol.org/schemas/v1/ to ensure exact compliance with v2.2.0 specification. Changes include: - All generated schema files updated from official spec - Fixed Union[] to X | Y syntax for Pydantic compatibility - Updated schema_helpers.py to use BrandManifest10 instead of BrandManifest8 - Ensures alignment between Pydantic models and JSON schemas - Maintains AdCP contract compliance for all API operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 23, 2025
The schema generation script was missing the --use-union-operator flag, causing it to regenerate all files with Optional[X] instead of X | None syntax whenever it ran. Changes: - Add --use-union-operator flag to datamodel-codegen command - Ensures generated schemas use modern Python 3.10+ syntax (X | None) - Prevents 70+ file changes every time schema generation runs - Fixes line wrapping inconsistencies in 14 schema files - Remove broken check-generated-schemas hook (script never existed) Root cause: PR #572 checked in schemas with X | None syntax, but the generator script still produced Optional[X] syntax, creating constant drift between committed files and regenerated files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 24, 2025
* Fix schema generator to use union operator for consistency The schema generation script was missing the --use-union-operator flag, causing it to regenerate all files with Optional[X] instead of X | None syntax whenever it ran. Changes: - Add --use-union-operator flag to datamodel-codegen command - Ensures generated schemas use modern Python 3.10+ syntax (X | None) - Prevents 70+ file changes every time schema generation runs - Fixes line wrapping inconsistencies in 14 schema files - Remove broken check-generated-schemas hook (script never existed) Root cause: PR #572 checked in schemas with X | None syntax, but the generator script still produced Optional[X] syntax, creating constant drift between committed files and regenerated files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply formatting consistency to schemas from PR #573 merge --------- Co-authored-by: Claude <noreply@anthropic.com>
EmmaLouise2018
pushed a commit
that referenced
this pull request
Oct 24, 2025
Regenerated all Pydantic schemas from official AdCP spec at https://adcontextprotocol.org/schemas/v1/ to ensure exact compliance with v2.2.0 specification. Changes include: - All generated schema files updated from official spec - Fixed Union[] to X | Y syntax for Pydantic compatibility - Updated schema_helpers.py to use BrandManifest10 instead of BrandManifest8 - Ensures alignment between Pydantic models and JSON schemas - Maintains AdCP contract compliance for all API operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
EmmaLouise2018
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Fix schema generator to use union operator for consistency The schema generation script was missing the --use-union-operator flag, causing it to regenerate all files with Optional[X] instead of X | None syntax whenever it ran. Changes: - Add --use-union-operator flag to datamodel-codegen command - Ensures generated schemas use modern Python 3.10+ syntax (X | None) - Prevents 70+ file changes every time schema generation runs - Fixes line wrapping inconsistencies in 14 schema files - Remove broken check-generated-schemas hook (script never existed) Root cause: PR #572 checked in schemas with X | None syntax, but the generator script still produced Optional[X] syntax, creating constant drift between committed files and regenerated files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply formatting consistency to schemas from PR #573 merge --------- Co-authored-by: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…#572) Regenerated all Pydantic schemas from official AdCP spec at https://adcontextprotocol.org/schemas/v1/ to ensure exact compliance with v2.2.0 specification. Changes include: - All generated schema files updated from official spec - Fixed Union[] to X | Y syntax for Pydantic compatibility - Updated schema_helpers.py to use BrandManifest10 instead of BrandManifest8 - Ensures alignment between Pydantic models and JSON schemas - Maintains AdCP contract compliance for all API operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…protocol#574) * Fix schema generator to use union operator for consistency The schema generation script was missing the --use-union-operator flag, causing it to regenerate all files with Optional[X] instead of X | None syntax whenever it ran. Changes: - Add --use-union-operator flag to datamodel-codegen command - Ensures generated schemas use modern Python 3.10+ syntax (X | None) - Prevents 70+ file changes every time schema generation runs - Fixes line wrapping inconsistencies in 14 schema files - Remove broken check-generated-schemas hook (script never existed) Root cause: PR adcontextprotocol#572 checked in schemas with X | None syntax, but the generator script still produced Optional[X] syntax, creating constant drift between committed files and regenerated files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply formatting consistency to schemas from PR adcontextprotocol#573 merge --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated all Pydantic schemas from official AdCP specification at https://adcontextprotocol.org/schemas/v1/ to ensure exact compliance with v2.2.0.
Changes
Union[]toX | Ysyntax for Pydantic compatibilityschema_helpers.pyto useBrandManifest10instead of deprecatedBrandManifest8Testing
Related
🤖 Generated with Claude Code