Fix schema generator to use union operator for consistency #574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The schema generation script was missing the
--use-union-operatorflag, causing it to regenerate all files withOptional[X]instead ofX | Nonesyntax whenever it ran. This created constant drift between committed schemas and regenerated ones.Changes
--use-union-operatorflag to datamodel-codegen commandX | None)check-generated-schemaspre-commit hook (script never existed)Root Cause
PR #572 committed schemas with
X | Nonesyntax, but the generator script still producedOptional[X]syntax, creating constant drift between committed files and regenerated files.Testing
Verification