-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint: upgrade to version 8.0.0 #3274
Conversation
Hola @Brianzchen 👋 Would you happen to know why are the tests failing because of |
So I raised an issue about this here. I guess I understand what this dodgy code does now. My projects are on eslint v8 but I suppose it never impacted me because I never used this rules. This is an easy fix let me raise a PR for you shortly |
@mrtnzlml I think this can be merged now that all the plugins have been updated! |
See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)
See:
Known unresolved issues (with low impact )that we decided to accept:
Known issues that need to be fixed first:
wait for Support ESLint 8.x mysticatea/eslint-plugin-node#294 to be released and merged herereplaced (probably temporarily) witheslint-plugin-n
which supports Eslint 8NEXT_VERSION_ERROR
toERROR
(Eslint config: convert allNEXT_VERSION_ERROR
toERROR
#3625)