refactor ingress backend pod detection #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2024
tjamet
force-pushed
the
maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3
branch
from
1860e09 to
ec84cff
Compare
tjamet
force-pushed
the
maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
branch
from
120e1fc to
fcaf4a0
Compare
Fsero
approved these changes
Nov 29, 2024
tjamet
force-pushed
the
maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3
branch
from
ec84cff to
d13fb31
Compare
tjamet
force-pushed
the
maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
branch
from
fcaf4a0 to
4b9b5dc
Compare
miguelbernadi
approved these changes
Dec 10, 2024
tjamet
force-pushed
the
maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3
branch
from
d13fb31 to
10007ac
Compare
tjamet
force-pushed
the
maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
branch
2 times, most recently
from
44c8ba4 to
93f6b3a
Compare
tjamet
force-pushed
the
maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3
branch
from
10007ac to
306e626
Compare
alfredolopezzz
approved these changes
Dec 12, 2024
tjamet
force-pushed
the
maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
branch
from
93f6b3a to
d69a594
Compare
Merged
tjamet
changed the title
Merged
tjamet
changed the base branch from
maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3
to
maiao.I9146086e1ed524e21ae073616ccbc73335769e68
Move the detection at the ingress level rather than per rule Goals --- - Prepare the case to support multiple ingress controllers through CRDs - Increase code readability and testeability Change-Id: I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
tjamet
force-pushed
the
maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65
branch
from
d69a594 to
a4dc767
Compare
tjamet
changed the title
tjamet
changed the base branch from
maiao.I9146086e1ed524e21ae073616ccbc73335769e68
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the detection at the ingress level rather than per rule
Goals
Committer details
Local-Branch: HEADRelated changes
Future changes
Prevent changing dnsEndpoint name and namespace attributes in createOrUpdate (#12)
This is not permitted by controllerRuntime and should not be performedRefactor DNS name extraction (#13)
Goal ---Ease the implementation of CRD based multi-ingress controller traffic routing
Add integration test (#16)
Goal ---Ensure that the chart provides enough privileges for the controller to work
Add fine-grain ingress DNS control through CRD (#14)
Context ---Handling usual cluster operations, we often come to operate higher risk changes like bumping ingress controller
versions, changing the underneath ingress service type (for example moving from an AWS ELB to an AWS NLB).
Doing so, the safest way would be to be able to provision a new ingress controller and progressively migrating traffic
to the new instance.
Problems
Currently, traffic controller reads the host and load balancer reference using
the ingress status.
This prevents from being able to handle and control weighted records across the different ingress controllers.
Goal
Enable fine-grained routing between various ingress controllers in the same cluster.
Unblocked use-cases