Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing dnsEndpoint name and namespace attributes in createOrUpdate #12

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tjamet
Copy link
Contributor

@tjamet tjamet commented Nov 29, 2024

This is not permitted by controllerRuntime and should not be performed

Committer details Local-Branch: HEAD
Related changes
Future changes
Refactor DNS name extraction (#13) Goal ---

Ease the implementation of CRD based multi-ingress controller traffic routing

Add integration test (#16) Goal ---

Ensure that the chart provides enough privileges for the controller to work

Add fine-grain ingress DNS control through CRD (#14) Context ---

Handling usual cluster operations, we often come to operate higher risk changes like bumping ingress controller
versions, changing the underneath ingress service type (for example moving from an AWS ELB to an AWS NLB).

Doing so, the safest way would be to be able to provision a new ingress controller and progressively migrating traffic
to the new instance.

Problems

Currently, traffic controller reads the host and load balancer reference using
the ingress status.

This prevents from being able to handle and control weighted records across the different ingress controllers.

Goal

Enable fine-grained routing between various ingress controllers in the same cluster.

Unblocked use-cases

  • Progressively change and test the ingress infrastructure (load balancer, ...) and versions
  • Allow sharding ingress controllers at the DNS level

@tjamet tjamet force-pushed the maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65 branch from fcaf4a0 to 4b9b5dc Compare December 10, 2024 10:54
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from c76cc2b to 12cac70 Compare December 10, 2024 10:54
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from 12cac70 to 85493fe Compare December 10, 2024 11:17
@tjamet tjamet force-pushed the maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65 branch 2 times, most recently from 44c8ba4 to 93f6b3a Compare December 10, 2024 11:43
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from 85493fe to b07a195 Compare December 10, 2024 11:43
@tjamet tjamet force-pushed the maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65 branch from 93f6b3a to d69a594 Compare December 13, 2024 06:51
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from b07a195 to a64daca Compare December 13, 2024 06:51
This was referenced Dec 13, 2024
@tjamet tjamet force-pushed the maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65 branch from d69a594 to a4dc767 Compare December 13, 2024 09:15
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from a64daca to 24a5d90 Compare December 13, 2024 09:15
…rUpdate

This is not permitted by controllerRuntime and should not be performed

Change-Id: I5f01e93edd2b8c48689588a871905047d4fbed8f
@tjamet tjamet force-pushed the maiao.I5f01e93edd2b8c48689588a871905047d4fbed8f branch from 24a5d90 to f7aeef7 Compare December 13, 2024 12:41
@tjamet tjamet changed the title [need #11] Prevent changing dnsEndpoint name and namespace attributes in createOrUpdate Prevent changing dnsEndpoint name and namespace attributes in createOrUpdate Dec 13, 2024
@tjamet tjamet changed the base branch from maiao.I14936b3ef0558e5d5b5fd6f251264ddfa7b8ad65 to main December 13, 2024 12:41
@tjamet tjamet merged commit 64f463d into main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants