Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline Design components must have transparent background [Web] #1423

Closed
5 tasks done
turolopezsanabria opened this issue Sep 12, 2023 · 1 comment · Fixed by #1478
Closed
5 tasks done

Outline Design components must have transparent background [Web] #1423

turolopezsanabria opened this issue Sep 12, 2023 · 1 comment · Fixed by #1478
Assignees
@acd02
Labels
✅ ready All the needed informations are detailed within the ticket to include it in another sprint
Milestone
2023 Q3 - Sprint 6

Comments

@turolopezsanabria
Copy link
Member

turolopezsanabria commented Sep 12, 2023 •
edited by acd02
Loading

✅ All components must have a background transparent in outline versions
✅ Tabs have a background transparent too

Task

  • Apply a background transparent to all components on rest/enabled
  • Don't change the current styles for hover, active, disabled, focus, etc. The current definition is still valid for the other states

Components affected

  • button
  • iconButton
  • tab
  • tag
  • chip
@turolopezsanabria turolopezsanabria added this to the Backlog milestone Sep 12, 2023
@thomas-leguellec thomas-leguellec added the ✍️ To refine The ticket must to be refine during "Refinement meeting" label Sep 13, 2023
@thomas-leguellec thomas-leguellec changed the title Outline components must have transparent background [Web] Outline Design components must have transparent background [Web] Sep 13, 2023
@thomas-leguellec thomas-leguellec added ✅ ready All the needed informations are detailed within the ticket to include it in another sprint P1 - Must Deliver and removed ✍️ To refine The ticket must to be refine during "Refinement meeting" labels Sep 13, 2023
@acd02 acd02 modified the milestones: Backlog, Q3 - Sprint 6 Sep 19, 2023
@acd02 acd02 self-assigned this Sep 19, 2023
acd02 added a commit that referenced this issue Sep 20, 2023
@acd02
feat(tag): update styles for outlined variant
35078af 
Apply a transparent bg for outlined variant

#1423
acd02 added a commit that referenced this issue Sep 20, 2023
@acd02
feat(tabs): update background styles
88e3381 
Apply no background color by default

#1423
@acd02 acd02 mentioned this issue Sep 20, 2023
Merged
9 tasks
@acd02 acd02 linked a pull request Sep 20, 2023 that will close this issue
feat: outline design components must have transparent background #1478
Merged
9 tasks
acd02 added a commit that referenced this issue Sep 21, 2023
@acd02
feat(tabs): update background styles
d2f4c97 
Apply no background color by default

#1423
acd02 added a commit that referenced this issue Sep 25, 2023
@acd02
feat(tabs): update background styles
ba0363d 
Apply no background color by default

#1423
@elisa-hery
Copy link

Background was only updated for tab and tag (for the other ones it was already done).
Tested and validated :

  • visual quality (appropriates variable tokens)
  • states and variations
  • browser compatibility (safari &chrome)

Hover invisibility will be handled later (slack thread here)

@acd02 FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acd02 acd02

Labels
✅ ready All the needed informations are detailed within the ticket to include it in another sprint
Projects
None yet
Milestone
2023 Q3 - Sprint 6
Development

Successfully merging a pull request may close this issue.

feat: outline design components must have transparent background adevinta/spark
4 participants
@turolopezsanabria @acd02 @thomas-leguellec @elisa-hery