feat: outline design components must have transparent background #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd02
requested review from
andresin87,
Powerplex,
kikoruiz,
turolopezsanabria and
soykje
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 618 618
Lines 4247 4247
Branches 1593 1593
=======================================
Hits 4156 4156
Misses 91 91
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Powerplex
approved these changes
Sep 20, 2023
kikoruiz
approved these changes
Sep 20, 2023
andresin87
reviewed
Sep 20, 2023
| @@ -7,7 +7,7 @@ export const triggerVariants = cva( | |||
| 'relative flex flex-none items-center', | |||
| 'border-outline', | |||
| 'outline-none', | |||
| 'bg-surface hover:bg-surface-hovered', | |||
andresin87
reviewed
Sep 20, 2023
| @@ -20,7 +20,7 @@ export const tagStyles = cva( | |||
| */ | |||
| design: makeVariants<'design', ['filled', 'outlined', 'tinted']>({ | |||
| filled: [], | |||
| outlined: ['bg-surface', 'ring-1', 'ring-current'], | |||
| outlined: ['bg-transparent', 'ring-1', 'ring-current'], | |||
There was a problem hiding this comment.
is not possible to simply remove the bg-[color] class?
andresin87
approved these changes
Sep 20, 2023
acd02
force-pushed
the
1423-outline-design-components-must-have-transparent-background-web
branch
from
88e3381 to
d2f4c97
Compare
Apply a transparent bg for outlined variant
Apply no background color by default #1423
acd02
force-pushed
the
1423-outline-design-components-must-have-transparent-background-web
branch
from
d2f4c97 to
ba0363d
Compare
acd02
deleted the
1423-outline-design-components-must-have-transparent-background-web
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK: #1423
Description, Motivation and Context
Types of changes