Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] - Tabs - add option to keep inactive tabs inside the DOM #2283

Closed
acd02 opened this issue Jul 1, 2024 · 0 comments · Fixed by #2284
Closed

[Component] - Tabs - add option to keep inactive tabs inside the DOM #2283

acd02 opened this issue Jul 1, 2024 · 0 comments · Fixed by #2284
Assignees
@acd02
Labels
Component: tabs Related to tabs component Component Related to a component Type: Enhancement
Milestone
2024 Q2 - Sprint 7

Comments

@acd02
Copy link
Contributor

acd02 commented Jul 1, 2024 •
edited
Loading

As of today, the Tab component thrashes inactive tabs.

An option to keep these tabs in the DOM, and simply hide them instead of removing them from the DOM would be beneficial, especially when Tab.Content loads heavy resources on mount, like high-definition images, videos, iframes, etc...
@acd02 acd02 self-assigned this Jul 1, 2024
@acd02 acd02 added Component Related to a component Component: tabs Related to tabs component Type: Enhancement labels Jul 1, 2024
@acd02 acd02 added this to the 2024 Q2 - Sprint 7 milestone Jul 1, 2024
@acd02 acd02 changed the title [Component] - Tabs - add option to keep inactive tabs Inside the DOM [Component] - Tabs - add option to keep inactive tabs inside the DOM Jul 1, 2024
acd02 added a commit that referenced this issue Jul 2, 2024
@acd02
feat(tabs): add keepMountedOnInactive prop to retain inactive tab con…
198c4fd 
…tent in the DOM

Add keepMountedOnInactive option to retain inactive tab content in the DOM

#2283
@acd02 acd02 mentioned this issue Jul 2, 2024
Merged
9 tasks
@acd02 acd02 linked a pull request Jul 2, 2024 that will close this issue
feat(tabs): add forceMount prop to retain inactive tab content in the DOM #2284
Merged
9 tasks
acd02 added a commit that referenced this issue Jul 2, 2024
@acd02
feat(tabs): add keepMountedOnInactive prop to retain inactive tab con…
a78f026 
…tent in the DOM

Add keepMountedOnInactive option to retain inactive tab content in the DOM

#2283
acd02 added a commit that referenced this issue Jul 3, 2024
@acd02
feat(tabs): add forceMount prop to retain inactive tab content in the…
decf930 
… DOM

Add forceMount option to retain inactive tab content in the DOM

#2283
acd02 added a commit that referenced this issue Jul 4, 2024
@acd02
feat(tabs): add forceMount prop to retain inactive tab content in the…
87c7ddd 
… DOM

Add forceMount option to retain inactive tab content in the DOM

#2283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acd02 acd02

Labels
Component: tabs Related to tabs component Component Related to a component Type: Enhancement
Projects
None yet
Milestone
2024 Q2 - Sprint 7
Development

Successfully merging a pull request may close this issue.

feat(tabs): add forceMount prop to retain inactive tab content in the DOM adevinta/spark
1 participant
@acd02