Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add forceMount prop to retain inactive tab content in the DOM #2284

Conversation

acd02
Copy link
Contributor

@acd02 acd02 commented Jul 2, 2024

TASK: #2283

Description, Motivation and Context

see related issue #2283

Types of changes

  • 🛠️ Tool
  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

@acd02 acd02 added Component Related to a component Component: tabs Related to tabs component labels Jul 2, 2024
@acd02 acd02 added this to the 2024 Q2 - Sprint 7 milestone Jul 2, 2024
@acd02 acd02 self-assigned this Jul 2, 2024
@acd02 acd02 linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (97ecc35) to head (87c7ddd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2284   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         760      760           
  Lines        6005     6008    +3     
  Branches     2102     2141   +39     
=======================================
+ Hits         5859     5862    +3     
  Misses        144      144           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acd02 acd02 force-pushed the 2283-component-tabs-add-option-to-keep-inactive-tabs-inside-the-dom branch from 198c4fd to a78f026 Compare July 2, 2024 11:58
@acd02 acd02 force-pushed the 2283-component-tabs-add-option-to-keep-inactive-tabs-inside-the-dom branch from a78f026 to decf930 Compare July 3, 2024 08:09
@acd02 acd02 changed the title feat(tabs): add keepMountedOnInactive prop to retain inactive tab content in the DOM feat(tabs): add forceMount prop to retain inactive tab content in the DOM Jul 3, 2024
Copy link
Contributor

@soykje soykje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

… DOM

Add forceMount option to retain inactive tab content in the DOM

#2283
@acd02 acd02 force-pushed the 2283-component-tabs-add-option-to-keep-inactive-tabs-inside-the-dom branch from decf930 to 87c7ddd Compare July 4, 2024 11:57
@acd02 acd02 merged commit a8ffe69 into main Jul 4, 2024
10 of 11 checks passed
@acd02 acd02 deleted the 2283-component-tabs-add-option-to-keep-inactive-tabs-inside-the-dom branch July 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: tabs Related to tabs component Component Related to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] - Tabs - add option to keep inactive tabs inside the DOM
2 participants