Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default box-shadow to Spark theme #860

Closed
acd02 opened this issue Jun 1, 2023 · 0 comments · Fixed by #861
Closed

Add default box-shadow to Spark theme #860

acd02 opened this issue Jun 1, 2023 · 0 comments · Fixed by #861
Assignees
@acd02
Labels
Type: Bug A bug to fix
Milestone
2023 Q2 - Sprint 5

Comments

@acd02
Copy link
Contributor

acd02 commented Jun 1, 2023 •
edited
Loading

The default box-shadow is missing from our Spark theme
see here -> https://sparkui.vercel.app/viewer/#Shadows

EDIT:
After investigation, it was discovered that the default box-shadow token was not missing.

Rather, the problem was that this token was in all uppercase, and our TCV config file was not handling theme token keys that were also in all uppercase properly. As a result, they were not displaying correctly on our TCV website.
@acd02 acd02 self-assigned this Jun 1, 2023
@acd02 acd02 added this to the Sprint 9 milestone Jun 1, 2023
@acd02 acd02 added the Type: Bug A bug to fix label Jun 1, 2023
acd02 added a commit that referenced this issue Jun 2, 2023
@acd02
fix: update TCV config file to include uppercased string edge cases
bc97aa3 
Update TCV config file to include uppercased string edge cases

#860
@acd02 acd02 linked a pull request Jun 2, 2023 that will close this issue
fix: update TCV config file to include uppercased string edge cases #861
Merged
9 tasks
@acd02 acd02 mentioned this issue Jun 2, 2023
Merged
9 tasks
acd02 added a commit that referenced this issue Jun 2, 2023
@acd02
fix: update TCV config file to include uppercased string edge cases
127eebe 
Update TCV config file to include uppercased string edge cases

#860
@acd02 acd02 closed this as completed in #861 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acd02 acd02

Labels
Type: Bug A bug to fix
Projects
None yet
Milestone
2023 Q2 - Sprint 5
Development

Successfully merging a pull request may close this issue.

fix: update TCV config file to include uppercased string edge cases adevinta/spark
1 participant
@acd02