Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update TCV config file to include uppercased string edge cases #861

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

acd02
Copy link
Contributor

@acd02 acd02 commented Jun 2, 2023

TASK: #860

Description, Motivation and Context

The theme token keys that were in all uppercase letters were not handled properly. As a result, they were not displaying correctly on our Tailwind Config Viewer website.

Types of changes

  • 🛠️ Tool
  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

@acd02 acd02 requested review from kikoruiz and soykje June 2, 2023 10:08
@acd02 acd02 self-assigned this Jun 2, 2023
@acd02 acd02 linked an issue Jun 2, 2023 that may be closed by this pull request
Update TCV config file to include uppercased string edge cases

#860
@acd02 acd02 force-pushed the 860-add-default-box-shadow-to-spark-theme branch from bc97aa3 to 127eebe Compare June 2, 2023 10:17
@acd02 acd02 merged commit 9df3323 into main Jun 2, 2023
@acd02 acd02 deleted the 860-add-default-box-shadow-to-spark-theme branch June 2, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default box-shadow to Spark theme
2 participants