Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from palantir:develop #553

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 21, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

New Features:

  • Introduce new icons related to table operations, including 'th-add', 'th-list-add', 'th-virtual', and 'th-virtual-add'.

Co-authored-by: svc-changelog <svc-changelog@palantir.com>
@pull pull bot added the ⤵️ pull label Nov 21, 2024
@pull pull bot merged commit 46d824a into admariner:develop Nov 21, 2024
Copy link

sourcery-ai bot commented Nov 21, 2024

Reviewer's Guide by Sourcery

This PR adds four new table-related icons to the Blueprint icon set. The implementation includes adding icon metadata to the icons.json configuration file and introducing the corresponding SVG files in both 16px and 20px sizes. A changelog entry has also been added to track this feature addition.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added metadata for four new table-related icons
  • Added 'Table: add' icon metadata with codepoint 62346
  • Added 'Table: list add' icon metadata with codepoint 62347
  • Added 'Table: virtual' icon metadata with codepoint 62348
  • Added 'Table: virtual add' icon metadata with codepoint 62349
packages/icons/icons.json
Added new SVG icon files in multiple sizes
  • Created 16px versions of all new table icons
  • Created 20px versions of all new table icons
resources/icons/16px/th-add.svg
resources/icons/16px/th-list-add.svg
resources/icons/16px/th-virtual.svg
resources/icons/16px/th-virtual-add.svg
resources/icons/20px/th-add.svg
resources/icons/20px/th-list-add.svg
resources/icons/20px/th-virtual.svg
resources/icons/20px/th-virtual-add.svg
Added changelog entry for the new icons packages/icons/changelog/@unreleased/pr-7067.v2.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants