Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MMDP icons #7067

Merged
merged 4 commits into from
Nov 21, 2024
Merged

New MMDP icons #7067

merged 4 commits into from
Nov 21, 2024

Conversation

Browun
Copy link
Contributor

@Browun Browun commented Nov 14, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Addind the following icons:

  • Table: virtual
  • Table: virtual add
  • Table: add
  • Table: list add

Reviewers should focus on:

Ensuring everything renders ok and the right files were changed.

Screenshot

Screenshot 2024-11-14 at 4 11 43 PM

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

New MMDP icons

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@ggdouglas ggdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean up these icons a bit? We can do the following:

  • Prefer viewBox to width/height
  • Remove all fill attributes
  • Remove all clip-rule attributes
  • Modify paths to use nonzero for fill-rule

packages/icons/icons.json Show resolved Hide resolved
resources/icons/16px/th-add.svg Show resolved Hide resolved
resources/icons/16px/th-list-add.svg Show resolved Hide resolved
resources/icons/16px/th-virtual-add.svg Show resolved Hide resolved
resources/icons/16px/th-virtual.svg Show resolved Hide resolved
resources/icons/20px/th-add.svg Show resolved Hide resolved
resources/icons/20px/th-list-add.svg Show resolved Hide resolved
resources/icons/20px/th-virtual-add.svg Show resolved Hide resolved
resources/icons/20px/th-virtual.svg Show resolved Hide resolved
* Update svg paths with suggested paths
@Browun Browun requested a review from ggdouglas November 21, 2024 11:16
@svc-palantir-github
Copy link

Pr comments * Update svg paths with suggested paths

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@Browun Browun merged commit 46d824a into develop Nov 21, 2024
13 checks passed
@Browun Browun deleted the browun/mmdp-icons branch November 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants