CIF-1480 -Move the react-components project from the Core Components to the Venia Project
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to the Venia Project Port the changes to the `main` branch
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 79.16% 79.16%
Complexity 13 13
=========================================
Files 1 1
Lines 24 24
Branches 4 4
=========================================
Hits 19 19
Misses 3 3
Partials 2 2
Continue to review full report at Codecov.
|
cjelger
approved these changes
Jul 10, 2020
nettree
added a commit
that referenced
this pull request
Jul 14, 2020
… to this project * Add previously added styles again to 'header.scss' and '_navigation.scss' as we changed the paths of these two files in other PR(#17) that has been merged to 'main' branch already
mhaack
added a commit
that referenced
this pull request
Jul 20, 2020
… in venia storefront (#10) * CIF-1211 - take over latest changes from old Venia - UrlProvider config & CSS * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - fix imageDelegate * CIF-1211 - take over latest changes from old Venia - UrlProvider config & CSS * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - fix imageDelegate * CIF-1444: Add 'miniaccount' component to header of wcm templates so that it can provide the mount point for 'miniaccount' CIF core component defined for AEM, add styles to hide 'miniaccount' component on header in tablet and mobile view(<1024px), hide 'miniaccount' component in navigation side panel on desktop, change title of 'miniaccount' component to correct one * CIF-1444: Migrate changes made for Venia from core CIF component repo to this project * Add previously added styles again to 'header.scss' and '_navigation.scss' as we changed the paths of these two files in other PR(#17) that has been merged to 'main' branch already * CIF-1507 - Setup the development tooling for Venia Remove configurations that we don't need. Exclude the `dist` folder from the babel-loader. This makes it possible for the `@adobe/aem-core-cif-react-components` to be linked via `npm link`. * Update README * Update the build configuration to support development installs: * Create a `fedProd` profile in POM (active by default) which produces a production build * Update the existing `fedDev` profile to run all the commands using the `exec-maven-plugin` instead of the `frontend-plugin`. This way all the build commands - `npm link`, `npm run dev` is executed in the context of the existing node installation. Update README to document the above changes. Co-authored-by: Markus Haack <mhaack@adobe.com> Co-authored-by: Zhi Wang <zhi.wang@aligent.com.au> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com>
herzog31
pushed a commit
that referenced
this pull request
Aug 3, 2020
* CIF-1211 - take over latest changes from old Venia - UrlProvider config & CSS * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - fix imageDelegate * CIF-1211 - take over latest changes from old Venia - UrlProvider config & CSS * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - prepare Dispatcher Config for Venia site * CIF-1211 - fix imageDelegate * CIF-1444: Add 'miniaccount' component to header of wcm templates so that it can provide the mount point for 'miniaccount' CIF core component defined for AEM, add styles to hide 'miniaccount' component on header in tablet and mobile view(<1024px), hide 'miniaccount' component in navigation side panel on desktop, change title of 'miniaccount' component to correct one * CIF-1398 - MyAccount - Address Book Page Create the structure for the account information pages. The root of the structure is the "Account" page which should contain the account information (implemented in a future PR). The Address Book page is a child of the "Account" page and only contains the address book management component. * CIF-1398 - MyAccount - Address Book Page Rename "Account" page to "My Account" and add the `hideInNav` property * CIF-1444: Migrate changes made for Venia from core CIF component repo to this project * Add previously added styles again to 'header.scss' and '_navigation.scss' as we changed the paths of these two files in other PR(#17) that has been merged to 'main' branch already * CIF-1398 - MyAccount - Address Book Page Add the "Address Book" proxy component * CIF-1398 - MyAccount - Address Book Page Move the "Address Book" component in the right place within the container * CIF-1507 - Setup the development tooling for Venia Remove configurations that we don't need. Exclude the `dist` folder from the babel-loader. This makes it possible for the `@adobe/aem-core-cif-react-components` to be linked via `npm link`. * Update README * Update the build configuration to support development installs: * Create a `fedProd` profile in POM (active by default) which produces a production build * Update the existing `fedDev` profile to run all the commands using the `exec-maven-plugin` instead of the `frontend-plugin`. This way all the build commands - `npm link`, `npm run dev` is executed in the context of the existing node installation. Update README to document the above changes. * CIF-1398: Install react-router package for react app * This will allow us to render component based on current URL path * CIF-1398: Add react router to react app * Add related configuration for address book component * Now react app can render address book based on the configured URL path * Please note at the moment the URL path is hard coded due to the base URL is suppose to be exposed by server, this will be handled later * CIF-1398: Change the path for address book in config.js Co-authored-by: Markus Haack <mhaack@adobe.com> Co-authored-by: Zhi Wang <zhi.wang@aligent.com.au> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Daniel Platon <dplaton@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #12 , but created for the
mainbranch.