CIF-1398 - [My Account] Address book management #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into latestchanges
…hat it can provide the mount point for 'miniaccount' CIF core component defined for AEM, add styles to hide 'miniaccount' component on header in tablet and mobile view(<1024px), hide 'miniaccount' component in navigation side panel on desktop, change title of 'miniaccount' component to correct one
Create the structure for the account information pages. The root of the structure is the "Account" page which should contain the account information (implemented in a future PR). The Address Book page is a child of the "Account" page and only contains the address book management component.
Rename "Account" page to "My Account" and add the `hideInNav` property
… to this project * Add previously added styles again to 'header.scss' and '_navigation.scss' as we changed the paths of these two files in other PR(#17) that has been merged to 'main' branch already
Add the "Address Book" proxy component
Move the "Address Book" component in the right place within the container
Remove configurations that we don't need. Exclude the `dist` folder from the babel-loader. This makes it possible for the `@adobe/aem-core-cif-react-components` to be linked via `npm link`.
* Create a `fedProd` profile in POM (active by default) which produces a production build * Update the existing `fedDev` profile to run all the commands using the `exec-maven-plugin` instead of the `frontend-plugin`. This way all the build commands - `npm link`, `npm run dev` is executed in the context of the existing node installation. Update README to document the above changes.
* This will allow us to render component based on current URL path
* Add related configuration for address book component * Now react app can render address book based on the configured URL path * Please note at the moment the URL path is hard coded due to the base URL is suppose to be exposed by server, this will be handled later
Conflicts: ui.frontend/src/main/components/App/App.js ui.frontend/src/main/components/App/config.js
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 79.16% 79.16%
Complexity 13 13
=========================================
Files 1 1
Lines 24 24
Branches 4 4
=========================================
Hits 19 19
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dplaton
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add address book component to the main React App, the render of address book is controlled by React router
Description
Add a new npm package
react-router-domso that we can control when to render the address book component inApp.jsAdd configuration values for address book component to
config.jsAdd
.content.xmlfiles for address bookRelated Issue
adobe/aem-core-cif-components#327
Motivation and Context
We need to provide the address book management in venia guides, this is a required feature
How Has This Been Tested?
The changes work with changes made in PR: adobe/aem-core-cif-components#353
Screenshots (if appropriate):
Types of changes
Checklist: