CIF-1654 - CIF React Core Components should support GraphQL GET requests #80
Conversation
…ia into issue/CIF-1654
herzog31
requested review from
cjelger,
dplaton,
hbacila,
laurentiumagureanu,
LSantha and
alkim91
| @@ -35,12 +35,13 @@ import partialConfig from './config'; | |||
| import '../../site/main.scss'; | |||
|
|
|||
| const App = () => { | |||
| const { storeView, graphqlEndpoint } = document.querySelector('body').dataset; | |||
| const { storeView, graphqlEndpoint, graphqlMethod } = document.querySelector('body').dataset; | |||
There was a problem hiding this comment.
I'm wondering whether we should make it more explicit that this setting affects only the queries and not the mutations...
There was a problem hiding this comment.
@dplaton good point. Where do you think would be the best place to document this?
There was a problem hiding this comment.
For the moment we can only leave a comment in the code. Sadly, we don't have any clear documentation now.
Codecov Report
@@ Coverage Diff @@
## dev #80 +/- ##
=========================================
Coverage 84.61% 84.61%
Complexity 16 16
=========================================
Files 1 1
Lines 26 26
Branches 4 4
=========================================
Hits 22 22
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
See adobe/aem-core-cif-components#426.