-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1654 - CIF React Core Components should support GraphQL GET requests #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The product part of the cart query needs to be identical across mutations and queries
…nents into issue/CIF-1654
herzog31
requested review from
dplaton,
cjelger,
LSantha,
hbacila,
laurentiumagureanu and
alkim91
October 21, 2020 15:04
dplaton
approved these changes
Oct 22, 2020
cjelger
approved these changes
Oct 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
============================================
+ Coverage 85.18% 85.23% +0.04%
- Complexity 1058 1061 +3
============================================
Files 219 220 +1
Lines 5421 5445 +24
Branches 780 785 +5
============================================
+ Hits 4618 4641 +23
- Misses 651 652 +1
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MagentoGraphqlClient
to expose the client configuration.StoreConfigExporterImpl
now read the GraphQL client configuration to export the configured HTTP method for GraphQL requests.page
component HTL to expose the HTTP method in the body tag.graphqlMethod
as new attribute toConfigContext
(also see Venia PR).compressQueryFetch
method. This is required because of limits of the Magento Cloud CDN. Otherwise for example thegetCartDetails
query exceeds the allowed URL length and is blocked.The integration test setup, that uses the CIF add-on will fail until a new add-on release which includes GraphQL client 1.7.0
Also see adobe/aem-cif-guides-venia#80.
How Has This Been Tested?
Types of changes
Checklist: