Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1253 - Product Carousel does not show configurable product and pr… #202

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Feb 17, 2020

…oduct variant of the same

How Has This Been Tested?

Extended unit tests.

Screenshots (if appropriate):

Screenshot 2020-02-17 at 14 38 02
Screenshot 2020-02-17 at 14 38 23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #202 into master will increase coverage by 0.09%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #202      +/-   ##
===========================================
+ Coverage      59.3%   59.4%   +0.09%     
- Complexity      528     536       +8     
===========================================
  Files           146     146              
  Lines          4332    4345      +13     
  Branches        727     734       +7     
===========================================
+ Hits           2569    2581      +12     
  Misses         1666    1666              
- Partials         97      98       +1
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.96% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 83.73% <95.23%> (+0.07%) 536 <2> (+8) ⬆️
Impacted Files Coverage Δ Complexity Δ
...nternal/models/v1/productlist/ProductListImpl.java 77.55% <100%> (+3.74%) 33 <0> (+7) ⬆️
...dels/v1/categorylist/FeaturedCategoryListImpl.java 86.95% <80%> (-2.41%) 15 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e11c94...5481e8e. Read the comment docs.

@cjelger cjelger added the bug Something isn't working label Feb 17, 2020
@dplaton dplaton merged commit 27755ce into master Feb 20, 2020
@dplaton dplaton deleted the CIF-1253 branch February 20, 2020 12:45
cjelger added a commit that referenced this pull request Mar 10, 2020
…h JCR path

- fixed regression bug introduced by #202
- extended unit test to make sure this is properly covered
LSantha added a commit that referenced this pull request Mar 12, 2020
…h JCR path (#220)

- fixed regression bug introduced by #202
- extended unit test to make sure this is properly covered

Co-authored-by: Levente Sántha <sntha@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants