Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1313 - Product carousel no longer displays product configured wit… #220

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Mar 10, 2020

…h JCR path

How Has This Been Tested?

Extended unit test + manually tested.

Screenshots (if appropriate):

Screenshot 2020-03-10 at 16 04 33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…h JCR path

- fixed regression bug introduced by #202
- extended unit test to make sure this is properly covered
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #220 into master will increase coverage by 3.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
+ Coverage     56.16%   60.09%   +3.93%     
- Complexity      537      539       +2     
============================================
  Files           138      147       +9     
  Lines          3928     4368     +440     
  Branches        744      745       +1     
============================================
+ Hits           2206     2625     +419     
- Misses         1630     1652      +22     
+ Partials         92       91       -1     
Flag Coverage Δ Complexity Δ
#jest 38.21% <ø> (ø) 0.00 <ø> (ø)
#karma 94.97% <ø> (?) 0.00 <ø> (?)
#unittests 84.88% <100.00%> (+0.08%) 539.00 <0.00> (+2.00)
Impacted Files Coverage Δ Complexity Δ
...models/v1/productcarousel/ProductCarouselImpl.java 87.27% <100.00%> (+2.36%) 21.00 <0.00> (+2.00)
...ommerce/product/v1/product/clientlib/js/gallery.js 94.87% <0.00%> (ø) 0.00% <0.00%> (?%)
...ctlist/v1/productlist/clientlibs/js/productlist.js 93.61% <0.00%> (ø) 0.00% <0.00%> (?%)
...merce/product/v1/product/clientlib/js/addToCart.js 96.42% <0.00%> (ø) 0.00% <0.00%> (?%)
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 88.33% <0.00%> (ø) 0.00% <0.00%> (?%)
...ctteaser/v1/productteaser/clientlibs/js/actions.js 92.30% <0.00%> (ø) 0.00% <0.00%> (?%)
...vigation/v1/navigation/clientlibs/js/navigation.js 98.66% <0.00%> (ø) 0.00% <0.00%> (?%)
...product/v1/product/clientlib/js/variantSelector.js 98.30% <0.00%> (ø) 0.00% <0.00%> (?%)
...ps/core/cif/clientlibs/common/js/PriceFormatter.js 90.90% <0.00%> (ø) 0.00% <0.00%> (?%)
...ommerce/product/v1/product/clientlib/js/product.js 96.29% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b044a...b184b7c. Read the comment docs.

@mhaack mhaack added the bug Something isn't working label Mar 11, 2020
@LSantha LSantha merged commit ac85b84 into master Mar 12, 2020
@LSantha LSantha deleted the CIF-1313 branch March 12, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants