CIF-2905: Experience Connector Extension #948
Conversation
| @@ -1,6 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
When removing the clientlib we have to make sure that we document this as breaking change in release notes. Otherwise the user of the react-components that do not use the new experience-platform-connector extension will run into issues.
Alternatively we could keep the clientlib and add a deprecation notice. Would this be possible?
extensions/experience-platform-connector/src/events-collector/handleEvent.js
Outdated
Show resolved
Hide resolved
| import { useEffect, useState } from 'react'; | ||
| import { default as handleEvent } from './handleEvent'; | ||
|
|
||
| export default ({ aep = null, snowPlow = null }) => { |
There was a problem hiding this comment.
We should better call it acds (Adobe Commerce DataSolutions) https://www.npmjs.com/package/@adobe/magento-storefront-events-sdk#user-content-seteventforwarding
|
|
||
| ```javascript | ||
| useEventsCollector({ | ||
| aep: { orgId: 'IMS ORG ID', datastreamId: 'The ID of the datastream used in AEP' } |
There was a problem hiding this comment.
we should add the Adobe Commerce DataSolutions configuration here.
|
|
||
| # Experience Platform Connector | ||
|
|
||
| This is a Javascript library collects Storefront events and forwards them to AEP. |
There was a problem hiding this comment.
| This is a Javascript library collects Storefront events and forwards them to AEP. | |
| This Javascript library collects Storefront events and forwards them to AEP. |
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
=========================================
Coverage 89.47% 89.47%
Complexity 2204 2204
=========================================
Files 351 351
Lines 9860 9860
Branches 1422 1422
=========================================
Hits 8822 8822
Misses 742 742
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Followed up on in |
Description
Introduced a Javascript library that collects storefront events and forwards them to AEP
Related Issue
CIF-2905
Motivation and Context
Send ACDL commerce events to AEP
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Types of changes
Checklist: