-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Experience Platform Connector events to Core Components #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4d42a6.
laurentiumagureanu
requested review from
buuhuu,
herzog31 and
LSantha
and removed request for
buuhuu
August 17, 2022 11:57
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
============================================
+ Coverage 89.46% 89.49% +0.02%
- Complexity 2204 2211 +7
============================================
Files 351 354 +3
Lines 9857 9967 +110
Branches 1422 1436 +14
============================================
+ Hits 8819 8920 +101
- Misses 742 750 +8
- Partials 296 297 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
herzog31
reviewed
Aug 17, 2022
ui.apps/src/main/content/jcr_root/apps/core/cif/clientlibs/storefront-events/js/collector.js
Outdated
Show resolved
Hide resolved
buuhuu
approved these changes
Aug 18, 2022
bundles/core/src/main/java/com/adobe/cq/commerce/core/components/storefrontcontext/Pricing.java
Show resolved
Hide resolved
10 tasks
herzog31
approved these changes
Sep 5, 2022
…omponents * adjusted package version to match project version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add necessary context and data for add to cart storefront event.
For Product Carousel, Product List, Product Teaser:
useAddToCartEvent()
hookxdm:discountAmount
to calculate the regularPrice (before discount)For Product:
data-cif-grouped-product-context
to the<tr>
element of each product in the group.useAddToCartEvent()
hookFor Search:
In general
Related Issue
CIF-2898
Motivation and Context
enables Beacon tracking
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: