Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamburger menu core component #1331

Merged
merged 33 commits into from
Oct 17, 2024
Merged

Hamburger menu core component #1331

merged 33 commits into from
Oct 17, 2024

Conversation

rajatofficial
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov Codecov
Copy link

codecov bot commented Aug 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (3ac02d4) to head (571f86b).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #1331      +/-   ##
============================================
+ Coverage     82.27%   82.30%   +0.03%     
- Complexity      923      925       +2     
============================================
  Files           103      103              
  Lines          2369     2374       +5     
  Branches        321      321              
============================================
+ Hits           1949     1954       +5     
  Misses          257      257              
  Partials        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@rismehta rismehta merged commit e6fa8bb into dev Oct 17, 2024
5 of 8 checks passed
@rismehta rismehta deleted the hamburgerMenuCoreComponent branch October 17, 2024 10:52
anshikag-adobe pushed a commit that referenced this pull request Oct 22, 2024
@rajatofficial @rajatkhurana-adobe @anshikag-adobe
Hamburger menu core component (#1331)
77309cc 
* initial commit

* hamburger menu enhanced

* code enhancement

* test case fixed

* sorting issue fixed

* hamburger menu enhancements

* test cases added

* nesting support till level 3

* breadcrumbs and two way sync added

* test cases fixes

* nesting level changed and commented code removed

* text changed

* test case added

* code refactored

* test cases fixed

* accessibility improvements

* custom nesting level support added

* nesting n level addded

* nesting support removed along with css cleanup

* test cases fixed

* cases fixed

* SOC implemented

* hamburger menu code restructured

* BEM fixed

* review comments incorporated

* java doc version update

* review comments incorporated II

* review comments incorporated II

* review comments incorporated II

* code refactoring

* code refactoring

* test cases fixes after bem change

* test cases fixes after bem change

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rismehta rismehta rismehta requested changes

@amit-mnnit amit-mnnit amit-mnnit left review comments

@barshat7 barshat7 barshat7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajatofficial @adobe-bot @barshat7 @amit-mnnit @rismehta @rajatkhurana-adobe