-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger menu core component #1331
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0f89f75
initial commit
rajatkhurana-adobe 2e0e805
hamburger menu enhanced
rajatkhurana-adobe 9a5dfb0
code enhancement
rajatkhurana-adobe 6ba6e0f
test case fixed
rajatkhurana-adobe c198674
sorting issue fixed
rajatkhurana-adobe 34bdcf8
hamburger menu enhancements
rajatkhurana-adobe 1f1e282
test cases added
rajatkhurana-adobe fa5766d
nesting support till level 3
rajatkhurana-adobe c34b1be
breadcrumbs and two way sync added
rajatkhurana-adobe 27308bb
test cases fixes
rajatkhurana-adobe f46e3e3
nesting level changed and commented code removed
rajatkhurana-adobe aaea659
text changed
rajatkhurana-adobe 73a28a1
test case added
rajatkhurana-adobe 61450be
code refactored
rajatkhurana-adobe d8d7245
test cases fixed
rajatkhurana-adobe 5297fe2
accessibility improvements
rajatkhurana-adobe 9726220
custom nesting level support added
rajatkhurana-adobe a7d5673
nesting n level addded
rajatkhurana-adobe 2f04e02
nesting support removed along with css cleanup
rajatkhurana-adobe 318d3c7
test cases fixed
rajatkhurana-adobe 6064805
cases fixed
rajatkhurana-adobe c37b0f5
SOC implemented
rajatkhurana-adobe 034f252
hamburger menu code restructured
rajatkhurana-adobe 7e86b94
BEM fixed
rajatkhurana-adobe ec0d64d
review comments incorporated
rajatkhurana-adobe 4d8aca8
java doc version update
rajatkhurana-adobe f4d5c6a
review comments incorporated II
rajatkhurana-adobe 4c3ab7a
review comments incorporated II
rajatkhurana-adobe 9f052be
review comments incorporated II
rajatkhurana-adobe ecc41c3
code refactoring
rajatkhurana-adobe 8e464e2
code refactoring
rajatkhurana-adobe 7f16a08
test cases fixes after bem change
rajatkhurana-adobe 381d55b
test cases fixes after bem change
rajatkhurana-adobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...n/content/jcr_root/content/forms/af/core-components-it/samples/formcontainer/.content.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal" | ||
jcr:mixinTypes="[rep:AccessControllable]" | ||
jcr:primaryType="sling:Folder" | ||
hidden="true"/> |
947 changes: 947 additions & 0 deletions
947
...ent/jcr_root/content/forms/af/core-components-it/samples/formcontainer/basic/.content.xml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases for all files reported by codecov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added all.