Theme editor changes #1477
Open
Theme editor changes #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
* Fixing gh workflow * Fixing GH actions
…nction (adobe#1464) * Focus on panel with static text not working via custom function * Fixing test
…#1462) * FORMS-15852 xss fix for svg upload in file upload * FORMS-15852 xss fix for svg upload in file upload II * FORMS-15852 xss fix for svg upload in file upload main * FORMS-15852 xss fix for svg upload in file upload main II * FORMS-15852 xss fix for svg upload in file upload main II * FORMS-15852 xss fix for svg upload in file upload main II --------- Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
…sProvider which are behind FT and make part of FormContainer get properties. (adobe#1467) Also updated FOrms SDK version
* sanitized text should have target attribute in links * catering comments * correcting test case * catering comments --------- Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Co-authored-by: Shivam Agarwal <shivama@adobe.com>
…#1470) * Adding new custom property for enable suggestions in bundles * Junit test cases to cover Enable Suggestions and Multi Selection in Dropdown * HTL template change + listener on checkbox * Cypress test for enable suggestions * Cypress test for enable suggestions * Remove enableSuggestions from JSON * Remove enableSuggestions from JUnit dropdown test json * Cypress tests for dropdown with autocomplete * Cypress tests for dropdown with autocomplete * Update classname for datalist * More Test cases to cover different values of enableSuggestions * Remove extra code * Simplified the return in enableSuggestions * Remove JsonIgnore annotation * JavaDoc for isEnableSuggestions * Bump up the minor version in package-info * Sort imports in dropdownimpl
* custom function registration using action url from backend custom function registration using action url from backend custom function registration using action url from backend * custom function registration using action url from backend custom function registration using action url from backend custom function registration using action url from backend * custom function registration using action url from backend * custom function registration using action url from backend * custom function registration using action url from backend * custom function registration using action url from backend - reusing the existing function * custom function registration using action url from backend - marked existing function as deprecated custom function registration using action url from backend - marked existing function as deprecated * Update FormContainer.java * formatting only * Update utils.js --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
adobe#1470)" This reverts commit ac662e9.
* using latest rotary image * Fixing version
| ValueMap themeProps = themeResource.getValueMap(); | ||
| themeClientLibRef = themeProps.get(ThemeConstants.PROPERTY_CLIENTLIB_CATEGORY, ""); | ||
| } else { | ||
| throw new GuideException("Invalid Theme Name " + themeContentPath); |
There was a problem hiding this comment.
remove GuideException, instead log an error
| @@ -28,6 +30,8 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| import com.adobe.aemds.guide.service.GuideException; | |||
There was a problem hiding this comment.
remove the import as well
muskgupta
force-pushed
the
ThemeEditorSupport
branch
from
86ee75e
to
05f84a4
Compare
Dev to master 15 nov 24
added 22 commits
November 21, 2024 14:15
muskgupta
force-pushed
the
ThemeEditorSupport
branch
from
da0a4d7
to
ef62442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to merge ThemeEditorPOC branch with master.
Related Issue
Theme Editor Feature
How Has This Been Tested?
Tested all changes on ThemeEditorPOC branch and locally as well.
Screenshots (if appropriate):
Types of changes
Checklist: