Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656

Open
abhinavsinha347 opened this issue Jan 10, 2024 · 1 comment
Open

Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656

abhinavsinha347 opened this issue Jan 10, 2024 · 1 comment

Comments

@abhinavsinha347
Copy link

Bug Report

Current Behavior
Below are the steps performed on vanilla instance with wknd site.

  1. Add accordion component on the page
  2. Edit the component.
  3. Select "Single item expansion" under properties tab.
  4. Under the Expanded item field we see "None" appears only once.
  5. Navigate to Items tab and add a new component. E.g text component.
  6. Check the "Expanded item" under properties tab. "None" option appears twice.

Expected behavior/code
"None" option should appear only once under "Expanded item"

Environment

  • AEM cloud version : 2023.10.13804.20231005T183332Z-230902
  • Core Components : 2.23.4

Possible Solution
Issue is because of accordion.js in /libs/core/wcm/components/accordion/v1/accordion/clientlibs/editor/js/accordion.js

Additional context / Screenshots
Screenshot 2024-01-10 at 11 00 55

recording.mp4
@abhinavsinha347
Copy link
Author

@joerghoh @klcodanr Is there any way this issue can be looked at ?

Ranjani-JSB added a commit to Ranjani-JSB/aem-core-wcm-components that referenced this issue Sep 13, 2024
@Ranjani-JSB
Accordion : Content editor dialog is adding "None" twice in Expanded …
bb4b3b4 
…items field adobe#2656 - Update accordion.js

adobe#2656
@Ranjani-JSB Ranjani-JSB mentioned this issue Sep 13, 2024
Closed
RaduADumitru added a commit that referenced this issue Nov 11, 2024
@RaduADumitru
Revert "Accordion : Content editor dialog is adding "None" twice in E…
377758a 
…xpanded items field #2656 - Update accordion.js"

This reverts commit bb4b3b4.
RaduADumitru added a commit that referenced this issue Nov 12, 2024
@RaduADumitru @Ranjani-JSB
SITES-26750 Accordion : Content editor dialog is adding "None" twice …
77dd95c 
…in Expanded Items field (#2890)

* Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656 - Update accordion.js

#2656

* Update accordion.js comments

* Minor text/formatting fixes

* Revert "Minor text/formatting fixes"

This reverts commit e9806cd.

* Revert "Update accordion.js comments"

This reverts commit affc079.

* Revert "Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656 - Update accordion.js"

This reverts commit bb4b3b4.

* Clean up all elements, not just ones with "" value

---------

Co-authored-by: Ranjani-JSB <jayaranjani.jayaprakash@corebridgefinancial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinavsinha347