Feature/video v1 #1624
Feature/video v1 #1624
Conversation
* Added video readme.md file
* Adapt general README file
…nents * Added Video Component type to adobe data layer * Adapted Unit tests to match the changes * Added placeholder to the component
* Added CQ Link Checker to verify the file reference * Unit Tests adaption
* fix getting link checker osgi service * create reference to content page
* Commit changes
* Adding data layer json properties export for the video component Contributing to Adobe data layer
|
Hey, @vladbailescu! Can you please take another look at this pr? I closed my last one and open this one. |
Codecov Report
@@ Coverage Diff @@
## development #1624 +/- ##
=================================================
+ Coverage 86.53% 86.68% +0.14%
+ Complexity 2197 2163 -34
=================================================
Files 207 207
Lines 5869 5798 -71
Branches 879 859 -20
=================================================
- Hits 5079 5026 -53
+ Misses 321 312 -9
+ Partials 469 460 -9
Continue to review full report at Codecov.
|
|
Hey @gabrielwalt ! I created a new pr with corrections of the last code review. On the last pr of the video component, i was told by @vladbailescu that i should ask you about if this is more for contrib repo or for the core component. Also can you please tell me what the next steps are to contributing? |
|
@georgecamilar , thanks again for your contribution, it's very much appreciated! As for next steps:
|
| * @since com.adobe.cq.wcm.core.components.models.datalayer 1.0.0 | ||
| */ | ||
| @JsonProperty("video") | ||
| default AssetData getAssetData() { |
There was a problem hiding this comment.
Would it make sense to add the poster here as well?
| * **Vendor**: Adobe | ||
| * **Version**: v1 | ||
| * **Compatibility**: AEM 6.4 | ||
| * **Status**: work-in-progress |
There was a problem hiding this comment.
Please add yourself/company as contributor!
gabriel-negrusa
force-pushed
the
feature/video-v1
branch
from
2324f9f
to
6bde62c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@vladbailescu @gabrielwalt any updates as to when we can expect this feature to be added to the core components? would be great to know if this is going to be part of the core components for further planning of the integration of multimedia components. Kind Regards |
|
@vladbailescu Regarding
Can you show your appreciation by either allowing this to be committed to contrib or to core components or outline what needs to be changed to somehow get this contribution integrated? |
|
@kwin , we will be taking this into one of our sprints beginning of 2023. |
|
@vladbailescu What is the state of this feature? |
Basic Video ComponentVideo component written in HTL that renders a video reference using the standard html5 player, with features like autoplay and loop. Also a poster can be used when the video is loading.