Forms 8863 #1080
Merged
Forms 8863 #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit23uec
reviewed
May 26, 2023
| @@ -29,3 +29,11 @@ | |||
| ></sly> | |||
| #end | |||
|
|
|||
| #if ($includeForms == "y" or $includeFormsenrollment == "y" or $includeFormscommunications == "y" or $includeFormsheadless == "y") | |||
| <sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html" | |||
| data-sly-use.formstructparser="com.adobe.cq.forms.core.components.models.form.FormStructureParser" | |||
There was a problem hiding this comment.
this will require a new release of core components being embedded in the archetype. lets update the cc version also in this PR else it will fail.
sakshi-arora1
approved these changes
Jun 7, 2023
|
pls check if we need similar changes for xfpage component also. sites's XFs are created from a template that uses a different page component (xfpage). |
10 tasks
ujjwal5
reviewed
Jun 8, 2023
| @@ -29,3 +29,11 @@ | |||
| ></sly> | |||
| #end | |||
|
|
|||
| #if ($includeForms == "y" or $includeFormsenrollment == "y" or $includeFormscommunications == "y" or $includeFormsheadless == "y") | |||
There was a problem hiding this comment.
we should include runtime clientlibs in xfpage as well.
Done |
rismehta
approved these changes
Jun 8, 2023
|
Please include forms data layer lib also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: