Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping core components version to use latest #1084

Closed
wants to merge 1 commit into from

Conversation

ujjwal5
Copy link

@ujjwal5 ujjwal5 commented Jun 6, 2023

Description

Bumping core components version to use latest

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@barshat7 barshat7 self-requested a review June 6, 2023 08:00
Copy link
Contributor

@barshat7 barshat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -74,7 +74,7 @@
<aio.runtime.namespace>${env.AIO_RUNTIME_NAMESPACE}</aio.runtime.namespace>
<aio.runtime.auth>${env.AIO_RUNTIME_AUTH}</aio.runtime.auth>
#end
<core.wcm.components.version>2.21.2</core.wcm.components.version>
<core.wcm.components.version>2.22.10</core.wcm.components.version>
Copy link
Contributor

@rismehta rismehta Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladbailescu Is it ok to change core wcm component version ?

@barshat7 barshat7 added this to the 42 milestone Jun 7, 2023
@barshat7
Copy link
Contributor

barshat7 commented Jun 8, 2023

This change is incorporated in #1080

@barshat7 barshat7 closed this Jun 8, 2023
@barshat7 barshat7 removed this from the 42 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants