-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --json flag to get command #61
Conversation
This reverts commit 0fe98f2.
Note that your tests fail under Windows because of pathing issues (I reverted my fixes above for Windows since the fix is not cross-platform -- your tests only run on Linux). I wasn't sure what the standard is for this repo for code coverage since there is no threshold set in the jest config. |
I added a new commit and the build.yml Github Action is not run. I think it's because your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR @shazron
We ll run the tests on Windows and fix if something's broken. Ideally, we run them on Linux but we do enforce tests to be OS-independent. We got it from here. Thank you 🙏
Description
Adds a
--json
flag to theapi-mesh:get
command.This gets rid of the selected org, project, and workspace logs, and a prefix log before the json output.
Existing output and strings are unchanged for backwards compatibility.
How Has This Been Tested?
aio plugins link .
in this PR branchTypes of changes
Checklist:
npm pack
)