Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --json flag to get command #61

Merged
merged 5 commits into from
Apr 28, 2023
Merged

feat: add --json flag to get command #61

merged 5 commits into from
Apr 28, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 13, 2023

Description

Adds a --json flag to the api-mesh:get command.
This gets rid of the selected org, project, and workspace logs, and a prefix log before the json output.

Existing output and strings are unchanged for backwards compatibility.

How Has This Been Tested?

  • aio plugins link . in this PR branch
  • aio api-mesh:get
  • aio api-mesh:get --json

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation (this should auto update when you publish via npm pack)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member Author

shazron commented Apr 13, 2023

Note that your tests fail under Windows because of pathing issues (I reverted my fixes above for Windows since the fix is not cross-platform -- your tests only run on Linux). I wasn't sure what the standard is for this repo for code coverage since there is no threshold set in the jest config.

@shazron
Copy link
Member Author

shazron commented Apr 13, 2023

I added a new commit and the build.yml Github Action is not run. I think it's because your pull_request types array doesn't have the synchronize type.

Copy link
Contributor

@revanth0212 revanth0212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR @shazron

We ll run the tests on Windows and fix if something's broken. Ideally, we run them on Linux but we do enforce tests to be OS-independent. We got it from here. Thank you 🙏

@amolina-adobe amolina-adobe mentioned this pull request Apr 28, 2023
10 tasks
@amolina-adobe amolina-adobe merged commit 58ad8ad into adobe:develop Apr 28, 2023
@amolina-adobe
Copy link
Contributor

amolina-adobe commented Apr 28, 2023

Hi @shazron, I pushed your branch to our repo and created a new PR #65. I needed to make a few additional changes, not to mention merge the changes from an outdated develop branch.

We will be publishing the package to npm soon. Thanks for your contributions!

@shazron shazron deleted the get-command-json-flag branch May 3, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants