Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pack throws getting api-mesh #774

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

MichaelGoberling
Copy link
Contributor

Description

Start using the --json flag when getting api-mesh during aio app pack and throw any resulting stderr

Related Issue

Closes #773

Motivation and Context

How Has This Been Tested?

Locally linked plugin, npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73a01b2) 100.00% compared to head (ce0e98d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #774   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3231      3232    +1     
  Branches       613       614    +1     
=========================================
+ Hits          3231      3232    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update this with --json, was waiting for the PR to be approved and forgot about it. Thanks Michael! adobe/aio-cli-plugin-api-mesh#61

@MichaelGoberling MichaelGoberling merged commit cb59ac5 into master Feb 22, 2024
7 checks passed
@MichaelGoberling MichaelGoberling deleted the fix-pack-undefined branch February 22, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack command failing with "Cannot read properties of undefined (reading 'includes')"
3 participants