Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Get url command #186

Merged
merged 15 commits into from
Apr 15, 2020
Merged

Conversation

sandeep-paliwal
Copy link
Contributor

Added command to return Action URLs

Description

For all actions in manifest
Specific action using 'action' option
CDN URLs for actions using 'cdn' flag

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests
CLI run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   92.20%   92.53%   +0.33%     
==========================================
  Files          20       21       +1     
  Lines         577      603      +26     
  Branches       73       75       +2     
==========================================
+ Hits          532      558      +26     
  Misses         40       40              
  Partials        5        5              
Impacted Files Coverage Δ
src/commands/app/get-url.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8ad68...8e1cd92. Read the comment docs.

}
}

GetUrlCommand.description = 'Get action URL'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Get action URLs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/commands/app/get-url.js Show resolved Hide resolved
test/commands/app/geturl.test.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants