Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue App init when Login timeouts #233

Merged
merged 18 commits into from
May 18, 2020
Merged

Conversation

sandeep-paliwal
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal commented May 18, 2020

Continue App init when Login timeouts.
Skip console generator in this case.
Fixes #225

Description

Related Issue

Motivation and Context

How Has This Been Tested?

manual run and unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

src/commands/app/init.js Show resolved Hide resolved
@shazron shazron merged commit bcf6fd1 into adobe:master May 18, 2020
@sandeep-paliwal sandeep-paliwal deleted the app_init branch June 8, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator only allows logged in user
2 participants