Event commands #260
Event commands #260
Conversation
Sync with Master
Sync with master
Sync with Master
Sync with Master
Sync with Master
Sync with master
Sync with master
Sync with Master
Sync with Master
Sync with Master
Sync with master
Sync with Master
Sync with master
Sync with Master
src/commands/app/add/event.js
Outdated
|
|
||
| const BaseCommand = require('../../../BaseCommand') | ||
| const yeoman = require('yeoman-environment') | ||
| const debug = require('debug')('aio-cli-plugin-app:init') |
There was a problem hiding this comment.
I don't think we should use debug anymore..
could you switch to aioLogger.debug ?
I would change the label too with the @adobe prefix..
const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:add:event', { provider: 'debug' })
There was a problem hiding this comment.
please do this everywhere :)
src/commands/app/add/event.js
Outdated
|
|
||
| debug(`adding component ${args.component} to the project, using flags: `, flags) | ||
|
|
||
| const services = (config.get('services') || []).map(s => s.code).join(',') |
There was a problem hiding this comment.
please remove the services argument, it's not used by the add-events generator..
src/commands/app/add/event.js
Outdated
| } | ||
| } | ||
|
|
||
| AddEventCommand.description = `Add a new event action |
There was a problem hiding this comment.
maybe let's rename this to Add a new Adobe I/O Events action
src/commands/app/delete/event.js
Outdated
| this.error('<action-name> must also be provided when using --yes=') | ||
| } | ||
|
|
||
| // todo should undeploy specific action ? |
src/commands/app/add/event.js
Outdated
| async run () { | ||
| const { args, flags } = this.parse(AddEventCommand) | ||
|
|
||
| debug(`adding component ${args.component} to the project, using flags: `, flags) |
There was a problem hiding this comment.
what is args.component? there is no args right?
just say adding a new events action to the project using flags: '${flags}'
src/commands/app/delete/event.js
Outdated
| async run () { | ||
| const { args, flags } = this.parse(DeleteEventCommand) | ||
|
|
||
| debug('deleting an action from the project, with args', args, 'and flags:', flags) |
There was a problem hiding this comment.
here when you will switch to aioLogger be careful as I don't think it supports multi args like debug() does
also deleting an events action..
src/commands/app/delete/event.js
Outdated
| name: 'action-name', | ||
| description: 'Action name to delete, if not specified you will choose from a list of actions', | ||
| default: '', | ||
| required: false |
There was a problem hiding this comment.
as discussed let's make this required and remove the if (flags.yes && !args['action-name']) {
also let's rename action-name to event-action-name
Updated tests based on these changes
generator plugin updated to use version 1.1.1
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 23 +2
Lines 775 808 +33
Branches 106 106
=========================================
+ Hits 775 808 +33
Continue to review full report at Codecov.
|
Added support to add/delete event actions using generators.
aio app:add:eventaio app:delete:eventaio app:delete:event <action-name>Description
Related Issue
Motivation and Context
How Has This Been Tested?
manual and unit tests
Screenshots (if appropriate):
Types of changes
Checklist: