Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACNA-1367] A clear error message when executing aio app commands outside of the application root #494

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Oct 11, 2021

Pick up error returned from executing commands outside an aio project and return an explicit error in exchange.

Description

⚠️ Pre-requisite ⚠️

adobe/aio-cli-lib-app-config#5 release

Related Issue

Fixes #488

Motivation and Context

How Has This Been Tested?

By executing aio app commands.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #494 (31f866d) into master (097a342) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         2267      2267           
  Branches       372       372           
=========================================
  Hits          2267      2267           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097a342...31f866d. Read the comment docs.

src/BaseCommand.js Outdated Show resolved Hide resolved
@shazron shazron merged commit 6fcbc23 into master Oct 13, 2021
@shazron shazron deleted the story/ACNA-1367-error-message-aio-app branch October 13, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a clear error message when executing aio app commands outside of the application root
2 participants