Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Resizing sidebar produces strange behavior in projects panel #1548

Closed
jbalsas opened this issue Sep 4, 2012 · 6 comments
Closed

Resizing sidebar produces strange behavior in projects panel #1548

jbalsas opened this issue Sep 4, 2012 · 6 comments

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Sep 4, 2012

When resizing the sidebar (doing it smaller), you can see two strange movements on the projects panel as if two new break lines where added.

Steps to reproduce:
  1. Open Brackets on the project folder
  2. Resize the sidebar until about half the size of the Brackets window (just to clearly see the effect as it happens anyway)
  3. Open one file. For example styles/brackets_codemirror_override.less
  4. Start resizing the sidebar making it smaller until it disappears
Result:
  • When the size of the sidebar is smaller than the name of the file, the div #open-files-container gains 9 additional pixels in height making the rest of the containers to move down.
  • When the size of the sidebar is smaller than the name of the project and the arrow indicator, div #project-files-header starts resizing, starting with the arrow indicator.
Expected result:
  • The project files container should not move
  • The project files header should not be resized
@ghost ghost assigned jasonsanjose Sep 11, 2012
@pthiess
Copy link
Contributor

pthiess commented Sep 11, 2012

Reviewed - assigned to JSJ

@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 31, 2012

This is not happening anymore. Probably since #1845 was merged.

@jbalsas jbalsas closed this as completed Oct 31, 2012
@redmunds
Copy link
Contributor

Yes, this looks much better. I still see some reflowing of contents that change height (i.e. project name + triangle). This should get fixed with enforcing a min-width which is captured in issue #998.

@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 31, 2012

Oh, you're right... I was testing with an old version of the shell so it was not loading the extensions and I wasn't seeing the reflow due to the RecentProjects one...

@redmunds I'm not sure enforcing a min-width will solve this as the project name could be really large, right? Should we reopen this issue to keep track of the triangle+recentProjects issue?

@redmunds
Copy link
Contributor

Yes. Re-opening for now.

@redmunds redmunds reopened this Oct 31, 2012
redmunds added a commit that referenced this issue Nov 5, 2012
Prevent reflow in the project name title (#1548)
@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2012

Confirmed fix. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants