This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Disable horizontal scrolling in working set view. #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -381,6 +381,9 @@ define(function (require, exports, module) { | |||
| ViewUtils.addScrollerShadow($openFilesContainer[0], null, true); | |||
| ViewUtils.sidebarList($openFilesContainer); | |||
|
|
|||
| // Disable horizontal scrolling until WebKit bug #99379 is fixed | |||
| $openFilesContainer.css("overflow-x", "hidden"); | |||
There was a problem hiding this comment.
Is there a reason why you are doing this in JS instead of in CSS?
There was a problem hiding this comment.
Yes - ViewUtils.sidebarList() sets overflow:auto in JavaScript, so CSS overrides don't work. We need to set this in JS, after calling ViewUtils.sidebarList().
ghost
assigned 
|
@RaymondLim - Randy reviewed the code but he's running Snow Leopard so he can't reproduce the original bug. Would you mind reviewing this request and make sure it fixes the bug? Thanks! |
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Oct 16, 2012
Disable horizontal scrolling in working set view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #1789.
Due to WebKit bug 99379, on OSX, when scrollbars are set to auto-hide, any item that is placed where the horizontal scrollbar will appear cannot be clicked.
Turning off horizontal scrolling doesn't seem too bad since there is no hierarchy in the working set list, so every item is aligned to the left side. I considered adding tooltips to the items, but that was distracting.
We could limit this change to OSX only if needed.