Brackets UI inconsistently uses hand cursor

[peterflynn]

The hand/link cursor appears over certain clickable elements in the Brackets UI, but not all. It feels inconsistent.

Elements that do use a hand cursor:

• Menu bar & menu items
• Quick Open dropdown items
• Buttons in modal dialogs
• "Used in file" swatches in color picker
• Toolbar icons
• "X" icon that closes panels
• Tabs/spaces controls in status bar

Elements that don't use a hand cursor:

• Working set & project tree items
• "Original value" swatch in color picker
• Clickable line items in search results / JSLint panels
• Recent projects dropdown & dropdown items
• Inline editor rule-list items
• Native menus & dialogs (obviously)

In some cases, the hand cursor might be a valuable indicator that a thing is clickable, but in many cases a rollover would do just as good a job -- so one potential option might be to not use the hand cursor anywhere. (Or use it only sparingly, on things that really are links).

[njx]

I think we should generally act like a desktop app (rather than a web page)--the fact that certain UI elements happen to be implemented as links shouldn't really be visible to the user. As you suggest, I think we should only have it for things that actually appear to the end user as links (and function like them).

[pthiess]

Reviewed

[njx]

FBNC to @peterflynn

[njx]

Note that the decision was to remove the hand cursor everywhere except for things that are actually hyperlinks (e.g. in the About dialog).

[peterflynn]

Verified fixed. I indeed only see the hand cursor on links.