Use default cursor on menu and toolbar items

[ZweiSteinSoft]

Fix for adobe/#2141.

[njx]

Looks like this fixes most but not all of the original bug cases--could you take a look at the remaining three:

• swatches in the inline color picker
• "x" in closable panels (e.g. Find in Files)
• tabs/spaces control in status bar

[ZweiSteinSoft]

What branch are you on? (1) I don't have a color picker. (2) Find, Replace and Find in Project show as toolbar above the code editor and disappear on blur, but don't have any close-X.

[njx]

The color picker is now in master if you merge with it--find a color in e.g. a CSS file and hit Cmd-E.

The closeable panel is with Find in Files (not Find). Do Edit > Find in Files, search for a string that's present somewhere in your project, and a panel will appear at the bottom listing the search results.

[njx]

Looks like you're adding a glow on mouseover to the swatches to indicate they're clickable. @GarthDB -- do you think we should keep that, or just remove it? (For context, this pull request is for #2141, which suggested that we remove the hand cursor everywhere and just use the pointer instead, since we're inconsistent about where we use the hand anyway, and we thought it would make sense to reserve the hand cursor for things that actually feel like links instead of things like buttons that happen to be implemented using an <a> tag.)

[GarthDB]

I would recommend leaving off the glow on the swatches, but I would leave the hand. In the creative suite applications they use the hand for clickable lists (layers, swatches, etc) and PS uses a color picker icon for the swatches.

[njx]

@GarthDB -- oh, interesting, I never noticed that. Could you take a look at all the cases listed in #2141 and indicate which ones you think we should keep the hand cursor for? (I'm assuming we would still want to use the standard arrow cursor for things like toolbar buttons.)

@mynetx -- I'll handle responding to Garth's changes once he makes the call on #2141 since it was my fault for not getting his input before you made all these updates :)

[GarthDB]

The overarching rule (though it is breakable) for the Creative Suite apps is dependent on whether they have a rollover state or not

Here's the list (hand cursor):

• "Used in file" swatches in color picker (pointer)
• Tabs/spaces controls in status bar (pointer)
• Working set & project tree items (pointer)
• "Original value" swatch in color picker (pointer)

And the default (arrow cursor):

• Menu bar & menu items (default)
• Quick Open dropdown items (default)
• Buttons in modal dialogs (default)
• Toolbar icons (default)
• "X" icon that closes panels (default)
• Clickable line items in search results / JSLint panels (default)
• Recent projects dropdown & dropdown items (default)
• Inline editor rule-list items (default)
• Native menus & dialogs (native- default)

[ZweiSteinSoft]

So what to do, @njx?

[njx]

@mynetx -- sorry, I've been swamped. If you have time to switch the "hand cursor" cases listed by @GarthDB back to using the hand cursor, that would be great.

[GarthDB]

Ok - In a meeting with topcoat syncing. We are recommending to not use the cursor:pointer; except for hyperlinks - so we are diverging from the Creative Suite in this case.

[ZweiSteinSoft]

So @GarthDB — what to change in this pull?

[GarthDB]

use cursor:default; for everything. And it looks like you are.

[njx]

It also sounds like you still need to remove the glow from the swatches--is that right, @GarthDB? And also merge with master. Once that's done we can pull it. Thanks!

[GarthDB]

This should be the only glow - on focus - mostly for tabbing through

[njx]

Finally getting around to merging this. Thanks for doing this!