Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Taskbar is ignored after resolution change #2180

Open
DennisKehrig opened this issue Nov 21, 2012 · 6 comments
Open

Taskbar is ignored after resolution change #2180

DennisKehrig opened this issue Nov 21, 2012 · 6 comments

Comments

@DennisKehrig
Copy link
Contributor

On Windows only:

  • Set a high screen resolution
  • Open Brackets
  • Resize the window to fill the screen (but do not maximize it)
  • Close Brackets
  • Set a lower screen resolution
  • Start Brackets

Expected: window is as big as the screen minus taskbar and other docked elements
Observed: window is as big as the screen and partially covered by the taskbar

The same goes for simply moving the window off screen on the bottom end. It is moved upwards when starting Brackets again, but not quite enough.

Marking low priority in correspondence with @gruehle (adobe/brackets-shell#144)

@njx
Copy link

njx commented Nov 26, 2012

Reviewed. To @redmunds.

@peterflynn
Copy link
Member

@JeffryBooher Do you know if this is fixed by your PR adobe/brackets-shell#498 too, or is this a different issue?

@JeffryBooher
Copy link
Contributor

@peterflynn it looks like that change doesn't use work area but rather virtual screen but it also doesn't appear that it's responding to resolution change messages. That would need aWM_SETTINGCHANGE message handler and possibly a WM_WININICHANGE handler as well to detect screen resolution/screen size changes while the app is running.

@peterflynn
Copy link
Member

@JeffryBooher In the bug description above, the screen resolution is changed while Brackets isn't running. I think you might have been thinking of a different issue...

@JeffryBooher
Copy link
Contributor

@peterflynn Sorry, I should have been more clear --

Reviewing that change, it doesn't look like it will take the work-area into consideration (the area not consumed by taskbars and other toolbars docked on the desktop) while rejiggering its size after restart so that would need to be fixed.

In addition to that, it should respond to the messages noted above while it is running to rejigger the window size so that it fits in the new work area. This may already be handled by Windows directly, however, so that could just be a test case for now.

@peterflynn
Copy link
Member

Ah, ok -- thanks for the info!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants