-
Notifications
You must be signed in to change notification settings - Fork 611
Conversation
Reviewing |
Works like a charm for the most part, definitely fixes adobe/brackets#2032! |
Is there an easy way to make the "Open file" dialog pop up on the same screen as where the window will appear? |
@redmunds Since you're not around this week, I'd suggest we merge this and you provide the task bar code later? After all this patch improves the situation and doesn't break anything, so I'd consider it safe. |
@DennisKehrig Yes, I think moving the window around the task bar is low priority. File another issue if you think that's important. Also, controlling where the "Open file" dialog is displayed is not related to this bug, so file another issue for that. |
adobe/brackets#2180 is the other one |
Ensure Brackets window is visible
Merged and closed :) |
Ensure Brackets window is visible
This is a Windows-only change for adobe/brackets#2032
In general, Brackets window should always be in view at start up.
Here are specific cases:
A. If screen resolution changes, window should be maximized to new size
B. If secondary screen moved or removed, should be maximized to primary (or other secondary) screen.
A. If screen resolution changes, window should be sized and positioned to fit on new size
B. If secondary screen moved or removed, should be sized and positioned to primary (or other secondary) screen.
C. If window is positioned partially off screen, it will be sized and positioned on screen.
This pull request only fixes Windows, but these tests should also be done on Mac.