Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Ensure Brackets window is visible #144

Merged
merged 1 commit into from
Nov 21, 2012
Merged

Conversation

redmunds
Copy link
Contributor

This is a Windows-only change for adobe/brackets#2032

In general, Brackets window should always be in view at start up.

Here are specific cases:

  1. For Maximized window, in primary or secondary screens:
    A. If screen resolution changes, window should be maximized to new size
    B. If secondary screen moved or removed, should be maximized to primary (or other secondary) screen.
  2. For non-maximized window, in primary or secondary screens:
    A. If screen resolution changes, window should be sized and positioned to fit on new size
    B. If secondary screen moved or removed, should be sized and positioned to primary (or other secondary) screen.
    C. If window is positioned partially off screen, it will be sized and positioned on screen.

This pull request only fixes Windows, but these tests should also be done on Mac.

@ghost ghost assigned DennisKehrig Nov 16, 2012
@DennisKehrig
Copy link
Contributor

Reviewing

@DennisKehrig
Copy link
Contributor

Works like a charm for the most part, definitely fixes adobe/brackets#2032!
However, when making sure that the non-maximized window fits on screen, the task bar is not taken into account (at least on Windows XP).
Try to move the window too far to the bottom or making it as high as possible - though it will fit on the screen, it will be partially covered by the taskbar.

@DennisKehrig
Copy link
Contributor

Is there an easy way to make the "Open file" dialog pop up on the same screen as where the window will appear?

@DennisKehrig
Copy link
Contributor

@redmunds Since you're not around this week, I'd suggest we merge this and you provide the task bar code later? After all this patch improves the situation and doesn't break anything, so I'd consider it safe.

@redmunds
Copy link
Contributor Author

@DennisKehrig Yes, I think moving the window around the task bar is low priority. File another issue if you think that's important.

Also, controlling where the "Open file" dialog is displayed is not related to this bug, so file another issue for that.

@DennisKehrig
Copy link
Contributor

adobe/brackets#2180 is the other one

DennisKehrig added a commit that referenced this pull request Nov 21, 2012
Ensure Brackets window is visible
@DennisKehrig DennisKehrig merged commit 1d88370 into master Nov 21, 2012
@DennisKehrig
Copy link
Contributor

Merged and closed :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants