[CLOSED] Ensure Brackets window is visible

[core-ai-bot]

Issue by redmunds
Friday Nov 16, 2012 at 00:22 GMT
Originally opened as adobe#144

---

This is a Windows-only change for adobe/brackets#2032

In general, Brackets window should always be in view at start up.

Here are specific cases:

1. For Maximized window, in primary or secondary screens:
   A. If screen resolution changes, window should be maximized to new size
   B. If secondary screen moved or removed, should be maximized to primary (or other secondary) screen.
2. For non-maximized window, in primary or secondary screens:
   A. If screen resolution changes, window should be sized and positioned to fit on new size
   B. If secondary screen moved or removed, should be sized and positioned to primary (or other secondary) screen.
   C. If window is positioned partially off screen, it will be sized and positioned on screen.

This pull request only fixes Windows, but these tests should also be done on Mac.

---

redmunds included the following code: https://github.com/adobe/brackets-shell/pull/144/commits

[core-ai-bot]

Comment by DennisKehrig
Tuesday Nov 20, 2012 at 14:41 GMT

---

Reviewing

[core-ai-bot]

Comment by DennisKehrig
Tuesday Nov 20, 2012 at 14:46 GMT

---

Works like a charm for the most part, definitely fixes adobe/brackets#2032!
However, when making sure that the non-maximized window fits on screen, the task bar is not taken into account (at least on Windows XP).
Try to move the window too far to the bottom or making it as high as possible - though it will fit on the screen, it will be partially covered by the taskbar.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Nov 20, 2012 at 14:48 GMT

---

Is there an easy way to make the "Open file" dialog pop up on the same screen as where the window will appear?

[core-ai-bot]

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 13:34 GMT

---

@redmunds Since you're not around this week, I'd suggest we merge this and you provide the task bar code later? After all this patch improves the situation and doesn't break anything, so I'd consider it safe.

[core-ai-bot]

Comment by redmunds
Wednesday Nov 21, 2012 at 15:40 GMT

---

@DennisKehrig Yes, I think moving the window around the task bar is low priority. File another issue if you think that's important.

Also, controlling where the "Open file" dialog is displayed is not related to this bug, so file another issue for that.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 16:18 GMT

---

adobe/brackets#2180 is the other one

[core-ai-bot]

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 16:19 GMT

---

Merged and closed :)