fix urls and strings pointers to localized getting started content #5038
Conversation
ghost
assigned 
|
@lkcampbell can you review? |
| @@ -35,6 +35,7 @@ define(function (require, exports, module) { | |||
| module.exports = { | |||
| root: true, | |||
| "de": true, | |||
| "fi": true, | |||
| "fr": true, | |||
| "es": true, | |||
There was a problem hiding this comment.
Minor point, did you want to sort these languages as well as long as you are making these changes?
|
@jasonsanjose initial review done. |
Conflicts: src/nls/strings.js src/nls/urls.js
|
@lkcampbell Fixes pushed. |
|
@jasonsanjose, the sk language is not listed in urls.js. Is that because the urls in the file point to English language resources instead of Slovak resources? |
|
@lkcampbell nice catch. It was probably due to my branch being out of sync initially. Anyhow, I removed the unnecessary |
|
@jasonsanjose, hmm...I think you removed the wrong urls.js. |
This reverts commit db82b52.
|
@lkcampbell I think I'm just having a bad day. 😅 Thanks for catching that! |
|
@jasonsanjose, okay I finally figured out how to use git to merge a remote branch into my local branch and play around with your fix :). I go to Switch Languages and the Slovak entry for the drop down menu says "sk" when it should probably say "Slovak". Is this fix supposed to address that? |
|
Pushed a fix to add Slovak locale name. Looks like it wasn't included in the original pull #4856. |
|
Okay, looks good, thanks. |
fix urls and strings pointers to localized getting started content
No description provided.