[HOLD] Dark Core UI

[larz0]

To see the Dark UI:

1. use brackets_core_ui_variables_dark.less in brackets_shared.less.
2. paste variables of brackets_core_ui_variables_dark.less into the appropriate core extension stylesheets.

[larz0]

@TomMalbran good idea! Forgot about that.

[larz0]

To see the Dark UI:

1. use brackets_core_ui_variables_dark.less in brackets_shared.less.
2. paste variables of brackets_core_ui_variables_dark.less into the appropriate core extension stylesheets.

[redmunds]

These files where the only changes are whitespace should not be part of the PR. It's unnecessary noise for reviewer and also for the file history.

[larz0]

Damn I think I have an extension that strips those out automatically. Do I need to add the whitespaces back?

[marcelgerber]

@redmunds For review, you can use this URL: https://github.com/adobe/brackets/pull/8362/files?w=0

[peterflynn]

@SAplayer That's definitely a good tip, but I agree with @redmunds's larger point that we should clean up the needless whitespace changes. There are 8 files in this PR that do nothing but touch whitespace unnecessarily.

[peterflynn]

I think we need to sort out the issues in #8420 before we can land this. I'm not entirely clear on how the color overriding works here, but at first glance it looks like it would suffer from the same problem.

But also I think we intended to punt this work to a future sprint, as part of https://trello.com/c/nhQxRyWn/518-theme-support-for-light-dark-mode -- and just focus on fixing #8379 for this release.

[larz0]

Ok sounds good.

[dangoor]

@larz0 It sounds like your schedule is pretty full today. I can take a crack at converting what you've done here to work with the new theme style.

[larz0]

Cool thanks @dangoor.

[peterflynn]

@larz0 I'm going to close this since we know we can't implement the dark colors using this approach. A lot of this has been ported to #8529 already, and I assume next sprint we can continue that approach to capture the rest of what's posted here (panel colors, etc.). As long as we don't delete the branch yet, we can still look at the diff here for reference: master...larz/css-refactor

[larz0]

@peterflynn ok sounds good as long as we're keeping this branch for reference.

[TomMalbran]

@larz0 @peterflynn What about having 2 less main files:

In light_ui.less we have

@import url("brackets_core_ui_variables_light.less");
@import url("brackets.less")

In dark_ui.less we have

@import url("brackets_core_ui_variables_dark.less");
@import url("brackets.less")

When switching themes with a different dark option we can switch the files. Also when compiling less we will get 2 files light_ui.css and dark_ui.less. So in production we switch between the CSS files instead.

[peterflynn]

@TomMalbran Exactly. See https://trello.com/c/nhQxRyWn/518-research-theming-improvements-maintainability for more discussion.

[TomMalbran]

@peterflynn Nice. I didn't saw that card. Anyway we shouldn't need any script to generate the files. We should only need manually create the files I mentioned and update the Gruntfile so that it compiles 2 less files instead of 1. We can even do something similar for extensions. They give the less file with the variables and we compile it. This can be done at the registry level or at runtime.