Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix #8541 (Inline editor content renders on top of gutter when scrolled horizontally) #8550

Merged
merged 1 commit into from
Jul 25, 2014

Conversation

JeffryBooher
Copy link
Contributor

Fixes #8541

This pr merges into kevin's inline-styling branch so this should be merged before #8529

@JeffryBooher
Copy link
Contributor Author

@dangoor

@@ -869,7 +869,7 @@ a, img {
background-color: transparent !important;

.CodeMirror-linenumbers {
background-color: transparent;
background-color: @tc-lighter-gray;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... This undoes a change that @larz0 made in #8362

@dangoor dangoor self-assigned this Jul 25, 2014
@dangoor dangoor merged commit 60c921f into dangoor/inline-styling Jul 25, 2014
@dangoor
Copy link
Contributor

dangoor commented Jul 25, 2014

It's not clear to me why @larz0 changed the background for .CodeMirror-linenumbers to be transparent in brackets.less, but this change does fix #8541 and looks fine to me in both light and dark themes.

@dangoor dangoor deleted the jeff/inline-styling branch July 25, 2014 12:05
@larz0
Copy link
Member

larz0 commented Jul 25, 2014

@dangoor it's transparent before you added the code below which does a good job at overriding line number bg in brackets.less so it's Jeff's change is totally fine.

.dark {
…
       .CodeMirror-scroll {
            .CodeMirror-linenumbers {
                background-color: @dark-bc-inline-widget;
            }
        }  
}

@dangoor
Copy link
Contributor

dangoor commented Jul 25, 2014

@larz0 I added the transparent because it was in your dark UI PR, but if you're cool with it and everything checks out, that's great!

This is already merged into the dangoor/inline-styling branch so it's ready to go.

@peterflynn peterflynn changed the title fix #8541 fix #8541 (Inline editor content renders on top of gutter when scrolled horizontally) Jul 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants