Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add generator for Visual Studio Code launch configuration #123

Merged
merged 8 commits into from
Jan 25, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 19, 2021

Add a generator to generate the Visual Studio Code launch configuration for a Project Firefly app.
The launch configuration enables debugging of actions via wskdebug, using aio app run or aio app run --local

Closes https://jira.corp.adobe.com/browse/ACNA-712

Motivation and Context

  • This is to replace the launch config generation in the @adobe/aio-cli-plugin-app plugin
  • This generator is to be run when adding or deleting an action in the app plugin (added to the add action and delete action commands)

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #123 (1ed6439) into master (bae82d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #123    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           22        25     +3     
  Lines          491       618   +127     
  Branches        60        82    +22     
==========================================
+ Hits           491       618   +127     
Impacted Files Coverage Δ
...enerators/add-vscode-config/VsCodeConfiguration.js 100.00% <100.00%> (ø)
generators/add-vscode-config/index.js 100.00% <100.00%> (ø)
generators/add-vscode-config/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae82d2...1ed6439. Read the comment docs.

@sandeep-paliwal
Copy link
Contributor

@shazron what happens when action is deleted? Do we run add-vs-code-config generator without the deleted action details and it overwrites the current config?

@shazron
Copy link
Member Author

shazron commented Jan 21, 2021

@shazron what happens when action is deleted? Do we run add-vs-code-config generator without the deleted action details and it overwrites the current config?

The generation of the vscode config is determined by the manifest, which is loaded by the app config loader. So as long as the app config reflects the current state of the app, the generator will base it off that. This generator will overwrite the existing vscode config.

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 868d1c6 into master Jan 25, 2021
@shazron shazron deleted the vscode branch January 25, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants