-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add generator for Visual Studio Code launch configuration #123
Conversation
100% code coverage
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 22 25 +3
Lines 491 618 +127
Branches 60 82 +22
==========================================
+ Hits 491 618 +127
Continue to review full report at Codecov.
|
@shazron what happens when action is deleted? Do we run add-vs-code-config generator without the deleted action details and it overwrites the current config? |
The generation of the vscode config is determined by the manifest, which is loaded by the app config loader. So as long as the app config reflects the current state of the app, the generator will base it off that. This generator will overwrite the existing vscode config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a generator to generate the Visual Studio Code launch configuration for a Project Firefly app.
The launch configuration enables debugging of actions via
wskdebug
, usingaio app run
oraio app run --local
Closes https://jira.corp.adobe.com/browse/ACNA-712
Motivation and Context
add action
anddelete action
commands)How Has This Been Tested?
npm test
Types of changes
Checklist: