Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation site takes 10-15 seconds to load #7

Closed
aaronshekey opened this issue Nov 16, 2018 · 7 comments
Closed

Documentation site takes 10-15 seconds to load #7

aaronshekey opened this issue Nov 16, 2018 · 7 comments
Labels
documentation Because documentation is important and shouldn't be broken

Comments

@aaronshekey
Copy link

aaronshekey commented Nov 16, 2018 •
edited
Loading

Expected Behavior

Loading the documentation site should be instant.

Actual Behavior

When loading the documentation site, it takes a good 10-15 seconds on the latest macOS Mojave and Safari via Gigabit internet.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Load normally http://opensource.adobe.com/spectrum-css/

Browser name/version/os (ie Chrome Version 62.0.3202.94 (Official Build) (64-bit) MacOS)

MacOS 10.14.1
Safari 12.0.1

screen shot 2018-11-16 at 3 16 38 pm
@GarthDB
Copy link
Member

GarthDB commented Nov 16, 2018 •
edited
Loading

Yeah, the biggest culprit is typekit. We are loading in all the languages for the typography examples and are looking into splitting it out into a separate page to handle the load time better.

@filmaj filmaj added documentation Because documentation is important and shouldn't be broken performance labels Nov 21, 2018
lazd added a commit that referenced this issue Dec 5, 2018
@lazd
Do syntax highlighting at build time with Prism, related to #7
809bd73
@lazd lazd mentioned this issue Dec 5, 2018
Merged
@lazd
Copy link
Member

lazd commented Dec 5, 2018

The docs are loading much faster after moving syntax highlight to a build-time task, but we'll leave this issue open until we have it much, much faster.

Try the 2.7.0 docs: http://opensource.adobe.com/spectrum-css/2.7.0/docs/

@aaronshekey
Copy link
Author

Are we testing Safari? I'm viewing this on Safari 12.0.1 on macOS 10.4.1 and the 2.7.0 and I'm not observing any performance gains and now beachballs in the process 😕. I'm not actually able to measure anything using dev tools since the browser freezes. 🤔

@GarthDB
Copy link
Member

GarthDB commented Dec 6, 2018

Checking it in Safari, it does load, but it's quite slow (it does show the beachball for a bit). It seems to hang on redirect a bit. I'm not sure what's going on there, but it does load... eventually 🤦‍♂️

image

@GarthDB
Copy link
Member

GarthDB commented Dec 6, 2018

It takes 17s to redirect, load, and render the page in safari (that's not the first load, so that would be with some caching help)
spectrum-css

lazd added a commit that referenced this issue May 22, 2019
@lazd
Break out multi-lingual Typography examples into their own page, closes
cc8aed9 
#7
@lazd lazd mentioned this issue May 22, 2019
Merged
lazd added a commit that referenced this issue May 22, 2019
@lazd
Break out multi-lingual Typography examples into their own page, rela…
90f2b60 
…ted to #7
lazd added a commit that referenced this issue May 24, 2019
@lazd
Separate out Typography examples, speed up docs, and be pretty about …
50eb95a 
…it (#175)

* Support separate examples, don't load all the fonts in the world unless we have a lang attribute somewhere on the page

* Break out multi-lingual Typography examples into their own page, related to #7

* Show a pretty little loader while the fonts are loading, closes #174

* Split out enhancements, docs, polyfills, into separate files

* Put the spectrum--scale class on the body

* Support HTML-only standalone examples

* Add a new Switcher class that can be used to switch Spectrum CSS files out
@lazd
Copy link
Member

lazd commented Oct 16, 2019

Fixed with the 2.14 docs site https://opensource.adobe.com/spectrum-css/2.14.0/docs/

@lazd lazd closed this as completed Oct 16, 2019
@aaronshekey
Copy link
Author

Nice work, y'all 🙌

This was referenced Apr 26, 2024
Merged
Closed
@github-actions github-actions bot mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Because documentation is important and shouldn't be broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@filmaj @GarthDB @lazd @aaronshekey