Fixes invalid card example images, fixes #11 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @benjamind |
benjamind
added a commit
to benjamind/spectrum-css
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled the example images from their locations on the corporate network and added them to the resources for the docs.
Description
These images as far as I can tell are public domain ones we've cropped down. The URLs were internal corp network references before, for stability of the site I've just included them in the resources/img folder.
Related Issue
#11
Motivation and Context
The internal urls were broken.
How Has This Been Tested?
Spun it up locally, and have tested the site on a mobile browser, and am no longer getting prompts for certificates.
Types of changes
Checklist: